diff options
| author | Vadim Yanitskiy <axilirator@gmail.com> | 2018-08-03 00:07:54 +0700 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2018-08-08 06:21:26 +0000 |
| commit | 3adb33de931c81fe696fdc48b535b54d816c9cfd (patch) | |
| tree | 11083ce00262018436d4558fd1fb20cbcc668a24 | |
| parent | 791ea72ee4c6e8aa4915db8172160bb4c2490580 (diff) | |
hlr_ussd.c: avoid using CR and NL in IUSE responses
According to GSM TS 03.38, section 6.1.2.1, CR symbol at the end
is optional, and moreover libosmogsm encoding API will carry
about the bit padding itself.
Change-Id: I09e8a67758698f3b7a578eab956311e269d091ee
| -rw-r--r-- | src/hlr_ussd.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/hlr_ussd.c b/src/hlr_ussd.c index 7b981bb..4ec9825 100644 --- a/src/hlr_ussd.c +++ b/src/hlr_ussd.c @@ -297,7 +297,7 @@ static int handle_ussd_own_msisdn(struct osmo_gsup_conn *conn, struct ss_session if (strlen(subscr.msisdn) == 0) snprintf(buf, sizeof(buf), "You have no MSISDN!"); else - snprintf(buf, sizeof(buf), "Your extension is %s\r", subscr.msisdn); + snprintf(buf, sizeof(buf), "Your extension is %s", subscr.msisdn); ss_tx_ussd_7bit(ss, true, req->invoke_id, buf); break; case -ENOENT: @@ -315,7 +315,7 @@ static int handle_ussd_own_imsi(struct osmo_gsup_conn *conn, struct ss_session * const struct osmo_gsup_message *gsup, const struct ss_request *req) { char buf[GSM0480_USSD_7BIT_STRING_LEN+1]; - snprintf(buf, sizeof(buf), "Your IMSI is %s!\n", ss->imsi); + snprintf(buf, sizeof(buf), "Your IMSI is %s", ss->imsi); ss_tx_ussd_7bit(ss, true, req->invoke_id, buf); return 0; } |