From 494d873fe394cfed228b21072cc173d412d6732a Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Thu, 29 Aug 2019 13:48:40 +0200 Subject: cosmetic: gtp: Drop commented out code calling pdp_freepdp() That code was commented out in 0b076a331e1e7f955580313a5da416c170b3b4ce (year 2003), and indeed it makes no sense to call those in current pdp lifecycle (they are expected to be freed by the application). Change-Id: I096d8cb8d749ff9b737d6f3f96b1d423660ece37 --- gtp/gtp.c | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/gtp/gtp.c b/gtp/gtp.c index 2ea949d..ba248c6 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -1752,8 +1752,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version, "Invalid message format\n"); if (gsn->cb_conf) gsn->cb_conf(type, EOF, pdp, cbp); - /* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp); - pdp_freepdp(pdp); */ return EOF; } @@ -1764,8 +1762,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version, "Missing mandatory information field\n"); if (gsn->cb_conf) gsn->cb_conf(type, EOF, pdp, cbp); - /* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp); - pdp_freepdp(pdp); */ return EOF; } @@ -1792,8 +1788,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version, "Missing conditional information field\n"); if (gsn->cb_conf) gsn->cb_conf(type, EOF, pdp, cbp); - /* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp); - pdp_freepdp(pdp); */ return EOF; } } @@ -1805,8 +1799,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version, "Missing conditional information field\n"); if (gsn->cb_conf) gsn->cb_conf(type, EOF, pdp, cbp); - /* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp); - pdp_freepdp(pdp); */ return EOF; } @@ -1818,8 +1810,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version, "Missing conditional information field\n"); if (gsn->cb_conf) gsn->cb_conf(type, EOF, pdp, cbp); - /* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp); - pdp_freepdp(pdp); */ return EOF; } @@ -1830,8 +1820,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version, "Missing conditional information field\n"); if (gsn->cb_conf) gsn->cb_conf(type, EOF, pdp, cbp); - /* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp); - pdp_freepdp(pdp); */ return EOF; } } @@ -1844,8 +1832,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version, "Missing conditional information field\n"); if (gsn->cb_conf) gsn->cb_conf(type, EOF, pdp, cbp); - /* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp); - pdp_freepdp(pdp); */ return EOF; } @@ -1856,8 +1842,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version, "Missing conditional information field\n"); if (gsn->cb_conf) gsn->cb_conf(type, EOF, pdp, cbp); - /* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp); - pdp_freepdp(pdp); */ return EOF; } } @@ -1869,8 +1853,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version, "Missing conditional information field\n"); if (gsn->cb_conf) gsn->cb_conf(type, EOF, pdp, cbp); - /* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp); - pdp_freepdp(pdp); */ } if (gtpie_gettlv(ie, GTPIE_EUA, 0, &pdp->eua.l, @@ -1881,8 +1863,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version, "Missing conditional information field\n"); if (gsn->cb_conf) gsn->cb_conf(type, EOF, pdp, cbp); - /* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp); - pdp_freepdp(pdp); */ return EOF; } @@ -1894,8 +1874,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version, "Missing conditional information field\n"); if (gsn->cb_conf) gsn->cb_conf(type, EOF, pdp, cbp); - /* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp); - pdp_freepdp(pdp); */ return EOF; } @@ -1907,8 +1885,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version, "Missing conditional information field\n"); if (gsn->cb_conf) gsn->cb_conf(type, EOF, pdp, cbp); - /* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp); - pdp_freepdp(pdp); */ return EOF; } @@ -1922,8 +1898,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version, "Missing conditional information field\n"); if (gsn->cb_conf) gsn->cb_conf(type, EOF, pdp, cbp); - /* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp); - pdp_freepdp(pdp); */ return EOF; } } -- cgit v1.2.3