From 12304c0e5ab4dedc8db6af0081d24cbdbba9ba41 Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Wed, 25 Nov 2020 18:49:16 +0100 Subject: ggsn: generate coredump and exit upon SIGABRT received Previous code relied on abort() switching sigaction to SIG_FDL + retriggering SIGABRT in case the signal handler returns, which would then generate the coredump + terminate the process. However, if a SIGABRT is received from somewhere else (kill -SIGABRT), then the process would print the talloc report and continue running, which is not desired. Change-Id: I7acfdfe5020320d853cba98b5add7479f8aaaf39 Fixes: OS#4865 --- ggsn/ggsn_main.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/ggsn/ggsn_main.c b/ggsn/ggsn_main.c index d9fb4e6..d19b359 100644 --- a/ggsn/ggsn_main.c +++ b/ggsn/ggsn_main.c @@ -71,6 +71,17 @@ static void signal_handler(int s) end = 1; break; case SIGABRT: + /* in case of abort, we want to obtain a talloc report and + * then run default SIGABRT handler, who will generate coredump + * and abort the process. abort() should do this for us after we + * return, but program wouldn't exit if an external SIGABRT is + * received. + */ + talloc_report(tall_vty_ctx, stderr); + talloc_report_full(tall_ggsn_ctx, stderr); + signal(SIGABRT, SIG_DFL); + raise(SIGABRT); + break; case SIGUSR1: talloc_report(tall_vty_ctx, stderr); talloc_report_full(tall_ggsn_ctx, stderr); -- cgit v1.2.3