aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2020-11-25 18:49:16 +0100
committerPau Espin Pedrol <pespin@sysmocom.de>2020-11-25 18:49:16 +0100
commit12304c0e5ab4dedc8db6af0081d24cbdbba9ba41 (patch)
treeaffe3d70a6aab1f265873fda61d5a0228bdc5567
parent1719abb4094f841f7cc7d26f68ea53061dccbbe2 (diff)
ggsn: generate coredump and exit upon SIGABRT receivedHEADmaster
Previous code relied on abort() switching sigaction to SIG_FDL + retriggering SIGABRT in case the signal handler returns, which would then generate the coredump + terminate the process. However, if a SIGABRT is received from somewhere else (kill -SIGABRT), then the process would print the talloc report and continue running, which is not desired. Change-Id: I7acfdfe5020320d853cba98b5add7479f8aaaf39 Fixes: OS#4865
-rw-r--r--ggsn/ggsn_main.c11
1 files changed, 11 insertions, 0 deletions
diff --git a/ggsn/ggsn_main.c b/ggsn/ggsn_main.c
index d9fb4e6..d19b359 100644
--- a/ggsn/ggsn_main.c
+++ b/ggsn/ggsn_main.c
@@ -71,6 +71,17 @@ static void signal_handler(int s)
end = 1;
break;
case SIGABRT:
+ /* in case of abort, we want to obtain a talloc report and
+ * then run default SIGABRT handler, who will generate coredump
+ * and abort the process. abort() should do this for us after we
+ * return, but program wouldn't exit if an external SIGABRT is
+ * received.
+ */
+ talloc_report(tall_vty_ctx, stderr);
+ talloc_report_full(tall_ggsn_ctx, stderr);
+ signal(SIGABRT, SIG_DFL);
+ raise(SIGABRT);
+ break;
case SIGUSR1:
talloc_report(tall_vty_ctx, stderr);
talloc_report_full(tall_ggsn_ctx, stderr);