From d8e2f0a68234aefcffde3723b84ce3ac69ee2c3e Mon Sep 17 00:00:00 2001
From: Pau Espin Pedrol <pespin@sysmocom.de>
Date: Tue, 26 Nov 2019 18:27:22 +0100
Subject: ansible: Fix several file permission mask format

From ansible documentation [1]:
"""
For those used to /usr/bin/chmod remember that modes are actually octal
numbers. You must either add a leading zero so that Ansible's YAML
parser knows it is an octal number (like 0644 or 01777) or quote it
(like '644' or '1777') so Ansible receives a string and can do its own
conversion from string into number.
Giving Ansible a number without following one of these rules will end up
with a decimal number which will have unexpected results.
"""

[1] https://docs.ansible.com/ansible/latest/modules/template_module.html?highlight=template

Change-Id: I91008927c50016a837420c4249b5f69b9153572e
---
 ansible/roles/gsm-tester/tasks/main.yml       | 10 +++++-----
 ansible/roles/install-coverity/tasks/main.yml |  3 +--
 ansible/roles/install-poky-sdk/tasks/main.yml |  3 +--
 3 files changed, 7 insertions(+), 9 deletions(-)

(limited to 'ansible/roles')

diff --git a/ansible/roles/gsm-tester/tasks/main.yml b/ansible/roles/gsm-tester/tasks/main.yml
index 34846a5..d880127 100644
--- a/ansible/roles/gsm-tester/tasks/main.yml
+++ b/ansible/roles/gsm-tester/tasks/main.yml
@@ -191,7 +191,7 @@
   file:
     path: /usr/sbin/tcpdump
     group: osmo-gsm-tester
-    mode: 750
+    mode: 0750
 
 - name: create a symlink for tcpdump
   file:
@@ -219,7 +219,7 @@
   copy:
     src: osmo-gsm-tester_setcap_net_raw.sh
     dest: /usr/local/bin/osmo-gsm-tester_setcap_net_raw.sh
-    mode: 755
+    mode: 0755
 
 - name: allow osmo-gsm-tester sudo osmo-gsm-tester_setcap_net_raw.sh
   copy:
@@ -232,7 +232,7 @@
   copy:
     src: osmo-gsm-tester_setcap_net_admin.sh
     dest: /usr/local/bin/osmo-gsm-tester_setcap_net_admin.sh
-    mode: 755
+    mode: 0755
 
 - name: allow osmo-gsm-tester sudo osmo-gsm-tester_setcap_net_admin.sh
   copy:
@@ -245,7 +245,7 @@
   copy:
     src: osmo-gsm-tester_netns_exec.sh
     dest: /usr/local/bin/osmo-gsm-tester_netns_exec.sh
-    mode: 755
+    mode: 0755
 
 - name: allow osmo-gsm-tester sudo osmo-gsm-tester_netns_exec.sh
   copy:
@@ -258,7 +258,7 @@
   copy:
     src: osmo-gsm-tester_netns_setup.sh
     dest: /usr/local/bin/osmo-gsm-tester_netns_setup.sh
-    mode: 755
+    mode: 0755
 
 - name: allow osmo-gsm-tester sudo osmo-gsm-tester_netns_setup.sh
   copy:
diff --git a/ansible/roles/install-coverity/tasks/main.yml b/ansible/roles/install-coverity/tasks/main.yml
index 200a349..886dda2 100644
--- a/ansible/roles/install-coverity/tasks/main.yml
+++ b/ansible/roles/install-coverity/tasks/main.yml
@@ -3,7 +3,7 @@
   copy:
     src: "{{ coverity_installer_file }}"
     dest: "/tmp/{{ coverity_installer_file }}"
-    mode: 750
+    mode: 0750
   register: coverity_copy
   ignore_errors: yes
   tags: [coverity]
@@ -36,4 +36,3 @@
     msg: "Ansible can not find {{ coverity_installer_file }}"
   when: coverity_copy.failed
   tags: [coverity]
-
diff --git a/ansible/roles/install-poky-sdk/tasks/main.yml b/ansible/roles/install-poky-sdk/tasks/main.yml
index 85b310a..7f95dce 100644
--- a/ansible/roles/install-poky-sdk/tasks/main.yml
+++ b/ansible/roles/install-poky-sdk/tasks/main.yml
@@ -12,7 +12,7 @@
   copy:
     src: "{{ poky_installer_file }}"
     dest: "/tmp/{{ poky_installer_file }}"
-    mode: 750
+    mode: 0750
   register: poky_copy
   ignore_errors: yes
   tags: [poky]
@@ -45,4 +45,3 @@
     msg: "Ansible can not find or copy {{ poky_installer_file }}"
   when: poky_copy.failed
   tags: [poky]
-
-- 
cgit v1.2.3