From 43c763f5af1dc2e21f0b092019d1e1a0f3851075 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Sat, 27 May 2017 11:15:17 +0200 Subject: osmo-bts-trx: Remove duplicate parsing of NM_ATT_CONN_FAIL_CRIT For some reason, osmo-bts-trx did another take at parsing NM_ATT_CONN_FAIL_CRIT and storing the second octet in btsb->radio_link_timeout, just like the generic code already does in oml_rx_set_bts_attr(), but without proper checking and any error message. Let's remove it. Change-Id: Idb0179e1443c0b5a97e59919dba684a001e90192 --- src/osmo-bts-trx/l1_if.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c index 336ffaba..a7bcd2c2 100644 --- a/src/osmo-bts-trx/l1_if.c +++ b/src/osmo-bts-trx/l1_if.c @@ -343,11 +343,6 @@ static uint8_t trx_set_bts(struct gsm_bts *bts, struct tlv_parsed *new_attr) uint8_t bsic = bts->bsic; struct gsm_bts_role_bts *btsb = bts_role_bts(bts); - if (TLVP_PRES_LEN(new_attr, NM_ATT_CONN_FAIL_CRIT, 1)) { - const uint8_t *val = TLVP_VAL(new_attr, NM_ATT_CONN_FAIL_CRIT); - btsb->radio_link_timeout = val[1]; - } - llist_for_each_entry(trx, &bts->trx_list, list) { struct phy_instance *pinst = trx_phy_instance(trx); struct trx_l1h *l1h = pinst->u.osmotrx.hdl; -- cgit v1.2.1