From 3e5b6db2d26f279f9238089f8c79de1d71a997aa Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Sat, 19 Apr 2014 19:22:22 +0200 Subject: handover: Call the right function and avoid recursion Fix a brown paper bag bug and call the right method. The above was an infinite recursion. The stack didn't overflow as the compiler optimized the tail-recursion and coverity didn't complain either. The issue was introduced in the last minutes before the merge when I renamed "reset_handover" to "handover_reset" to follow the object_verb approach throughout the handover.c code. While doing that I sadly replaced reset_handover with handover_frame and not handover_reset. --- src/common/handover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/handover.c b/src/common/handover.c index ab3cbcf8..26a3f51a 100644 --- a/src/common/handover.c +++ b/src/common/handover.c @@ -143,7 +143,7 @@ void handover_frame(struct gsm_lchan *lchan) { LOGP(DHO, LOGL_INFO, "%s First valid frame detected\n", gsm_lchan_name(lchan)); - handover_frame(lchan); + handover_reset(lchan); } /* release handover state */ -- cgit v1.2.3