aboutsummaryrefslogtreecommitdiffstats
path: root/src/common/sysinfo.c
AgeCommit message (Collapse)AuthorFilesLines
2017-06-26RSL: receive and send multiple SI2q messagespespin/osmo-gsm-testerMax1-1/+15
* change BCCH Info handler to explicitly support multiple SI2quater messages sent from BSC * change SI scheduler to send SI2q in round-robin way That's resubmission of 340cff51f49f6e798cb5fb6d1b9febdd09902906 and 186c6bac0758b6f94aa101e151664b0dea5d8975 with memory initialization order change to fix the issue detected by osmo-gsm-tester - see OS#2338. Change-Id: Ib595733cde108387bc7ee76b1b11ada6a235f13c Related: OS#1660, OS#2338
2017-06-24Revert "RSL: receive and send multiple SI2q messages"Neels Hofmeyr1-15/+1
This reverts commit 340cff51f49f6e798cb5fb6d1b9febdd09902906. osmo-gsm-tester detected a regression due to this commit, when running osmo-bts-trx. The modems timed out when waiting for them to register with the osmo-bts-trx network. osmo-bts-sysmo is apparently not affected. No further details on the failure cause are known yet. The failure is shown for example by http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_run/868/ Change-Id: I15bca30ddc09a7a3044096626016f6130d07636c
2017-06-15RSL: receive and send multiple SI2q messagesMax1-1/+15
* change BCCH Info handler to explicitly support multiple SI2quater messages sent from BSC * change SI scheduler to send SI2q in round-robin way Change-Id: I3aeb90804edab1b0325c3eb7347526ae995dbf51 Related: OS#1660
2017-06-15Cleanup SI schedulingMax1-20/+12
* use GSM_BTS_HAS_SI() from OpenBSC instead of local copy * arrange GSM_BTS_HAS_SI() checks to improve readability * constify SI scheduler parameters Change-Id: If74bc536fe7d2bfbc976c07d882151873ecda4f2 Related: OS#1660
2017-05-09Prepare for extended SI2quater supportMax1-1/+1
SI2quater support as per 3GPP TS 44.018 will require chnages to the way System Information is stored because it uses 1:n instead of 1:1 mapping between SI type and generated SI content. This should not affect other SI types though. To facilitate this transition: * convert the code to always use GSM_LCHAN_SI helper instead of accessing buffer directly * move duplicated code to inline function * add logging for buffer truncation and corresponding length values Requires I74e4e3cb86364cec869a1472a41b4a95af0d50dd in OpenBSC. Change-Id: Ie97be6ead6ce6d2d425fbfac8429bb90afb95acc Related: RT#8792
2017-02-10cosmetic: lchan_sacch_get: early-exit instead of nested-ifNeels Hofmeyr1-4/+4
Change-Id: I1fbf7d7f619cc8194c8094cf4a1826b6114f0e11
2016-12-01Fix AGCH/PCH proportional allocationMax1-0/+14
Do not assume that 1 == BS_AG_BLKS_RES but take that information from SI3. Note: due to current implementation quirks we activate channels before SI3 obtained, than we deactivate channels upon receiving SI3 and activate them again. This might not be necessary once we migrate to proper OML state machines. This affects lc15 and sysmo hw. Change-Id: I11377b12680ac3b2f77f80e742b6f0af63fc9c1e Related: OS#1575
2016-03-17Fix SI2ter schedulingMax1-2/+3
According to 3GPP TS 05.02 ยง 6.3.1.3 SI2ter messages should be scheduled in FN with TC=4 only if SI2bis messages are also available.
2016-03-11Fix copy-paste issueMax1-1/+1
This issue prevented scheduling of SI 2quater messages.
2014-05-22common: Ignore "si.valid" outside of _MAX_SYSINFO_TYPEHolger Hans Peter Freyther1-1/+1
Limit the range from 0 to (_MAX_SYSINFO_TYPE - 1) instead of 0 to 31. This way we will never access the lchan->si.buf[] out of bounds. This is only a theoretical issue though as the code filling the lchan->si.buf for the SACCH will not have valid >= _MAX_SYSINFO_TYPE. Add a small regression test to check we still schedule all SIs. Fixes: CID 1040765
2014-05-22common: Remove unused gsm_time parameter from lchan_sacch_getHolger Hans Peter Freyther1-1/+1
2012-06-14system information: avoid modulo 0 / SIGFPEHarald Welte1-3/+8
As Holger pointed out, it may well be the case that there are no system information messages to be sent at TC=4, and we should avoid a modulo by 0. I'm simply sending SI2 instead now, as it isn't forbidden to send it more often than the minimum at TC=2...
2012-06-03sysinfo: Make our SI scheduling more completeHarald Welte1-5/+80
We now implement the fairly complex rules for schedulign of SI 2bis/2ter/2quater, 13 and 9 on TC=4 and TC=5 of the BCCH Norm. The patch is currently untested.
2012-06-02sysinfo: Schedule SI 2bis and 2terHarald Welte1-4/+4
In case we have neighbor cells in different bands, we should send those SI...
2011-06-29remove debugging printf in sysinfo codeHarald Welte1-1/+0
2011-06-27re-work original osmo-bts with support for sysmocom femtobtsHarald Welte1-0/+66
This code re-works osmo-bts to add support for the upcoming sysmocom BTS. It also tries to add some level of abstraction between the generic part of a BTS (A-bis, RSL, OML, data structures, paging scheduling, BCCH/AGCH scheduling, etc.) and the actual hardware-specific bits. The hardware-specific bits are currently only implemented for the sysmocom femtobts, but should be (re-)added for osmocom-bb, as well as a virtual BTS for simulation purpose later. The sysmocom bts specific parts require hardware-specific header files which are (at least currently) not publicly distributed.