aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-04-06VIRT-PHY: Extracted common virtphy utils.stumpf/virt-phySebastian Stumpf4-77/+98
2017-03-04VIRT-PHY: TCH processed as FACCH to enable signaling on TCH.Sebastian Stumpf1-11/+9
2017-02-28VIRT-PHY: Added test option for fast hyperframe repeat.Sebastian Stumpf2-3/+8
Frame number will restart at 0 after each superframe (approx. 6.1 sec) if enabled. Can be enabled by preprocessor define.
2017-02-27VIRT-PHY: Fixed error causing send msgs to be received on same sock.Sebastian Stumpf1-1/+9
This could be disabled setting socket option IP_MULTICAST_ALL = 0.
2017-02-26VIRT-PHY: Using IANA-registered port 4729 for GSMTAP for virt um.Sebastian Stumpf3-6/+6
2017-02-25VIRT-PHY: Fixed timeslot in gsmtap-msg on downlink which was always 0.Sebastian Stumpf1-0/+2
Timeslot is not encoded in the chan_nr accessible in the channel description but was taken from there and so it was always 0.
2017-02-13VIRT-PHY: Uplink flag and arfcn check for incoming messages.Sebastian Stumpf1-0/+13
All incoming messages with an arfcn unequal that of the bts are ignored. All incoming messages in which the uplink flag in the arfcn is unset are ignored.
2017-02-10VIRT-PHY: Fixed invalid value authorized-regexp in bsc example config.Sebastian Stumpf1-4/+43
2017-02-06VIRT-PHY: Cleanup dirs, makefile, dependencies and formatting code.Sebastian Stumpf15-43/+43
2017-02-02VIRT_PHY: Proper gsmtap hdr info to rsl chan_nr parsing and vice-versa.Sebastian Stumpf2-52/+170
2017-01-26VIRT-PHY: Forward RACH on uplink with received values.Sebastian Stumpf3-15/+27
Dummy values are no longer used, but the received ra content parsed from the gsmtap msg data and forwarded to the upper layer. Minor changes: Comments, removed unnecessary code.
2017-01-26Merge branch 'stumpf/virt-phy' of https://github.com/osmocom/osmo-bts.git ↵Sebastian Stumpf0-0/+0
into stumpf/virt-phy
2017-01-23VIRT-PHY: Added example configurations for openbsc and osmobts.Sebastian Stumpf3-0/+262
Change-Id: I368d4a378e20028603b09825eee766abb9195774
2017-01-23VIRT-PHY: Added functionality to cooperate with osmocom-bb virt-phy.Sebastian Stumpf28-391/+1640
This patch improves the virtual physical layer designed to replace the air interface. The purpose is to get rid of the hardware requirements and be able to start testing and implementing layer 2 communication functionality on one machine. Multicast sockets are used to enable bidirectional communication between the BTS and the MS process. The GSMTAP protocol designed for wireshark capturing is used to encapsulate the payload on the virtual physical layer. * Working mcast socket communication and extraction of its functionality. * Fixed OML and RSL startup sequences. * Icludes tests for mcast socket and virtual UM. * Ecapsulation and parsing methods to and from GSMTAP messages. * Basic handlers for file descriptor callbacks from incoming mcast messages. * Multiplexing to different channels based on GSMTAP header channel type.
2017-01-23WIP: Initial check-in of a new virtual BTSHarald Welte13-1/+1586
2017-01-20deb: use gsm_data_shared.* from openbsc-devMax3-1/+21
Use gsm_data-shared.* from absolute path where it's installed by openbsc-dev package instead of relative path to fix OBS package building. Change-Id: Iec6b0f0eb0b7fffaa814c9769c0ee777d641a07f Related: OS#1860
2017-01-16l1sap: fix missing 'else's causing wrong rach frame expiry countsPhilipp1-2/+2
This bug was introduced in the recently merged commit 1e399f888e4e1c93e0e5b7fd69fce09a2587fb87 aka change-id I87f40f5f160a4f6750c4f3d06997fc4f24049303 Fixes: coverity-scan CID#160156 and CID#160155 Change-Id: I88ed1b3e59213acdf97f88eda097b8172b952a5e
2017-01-12l1sap: Fix expired rach slot countingPhilipp1-16/+56
The counting of the expired rach slots in l1sap.c is not correctly implemented. This commit fixes the implementation. The expired rach slots are now conted correctly according to the configured channel combination. If a CCCH and SDCCH are combined, only the frames related to rach slots are counted. Change-Id: I87f40f5f160a4f6750c4f3d06997fc4f24049303
2017-01-12lc15,sysmobts l1_if: fix memleak in handle_mph_time_ind()Jean-Francois Dionne2-0/+2
Change-Id: I3061060235a488b114b636b3af9a2253a94de1e8
2017-01-10scheduler: log lchan on which prim error occuredMax2-4/+53
Log both lchan and trx_chan_type (using introduced value_string). Change-Id: I80c581b54eeee371ee524a75a400d1e9ece16c68
2017-01-10DTX: fix SID-FIRST detectionJean-Francois Dionne2-2/+2
Max's note: made similar modification to osmo-bts-sysmo/tch.c Change-Id: I76e62783b73803dfc0d32693a68020a9d89878b8 Related: OS#1801
2017-01-10Remove obsolete define TLVP_PRES_LENMax1-5/+0
The libosmocore version required by configure.ac already has TLVP_PRES_LEN anyway. Change-Id: I3e33d9d1a6160ea17ab0a875c65a98129e3d19c1
2017-01-10CTRL: make the CTRL-Interface IP address configurablePhilipp3-4/+12
Currently the IP address where the control interface is bound to is hardcoded to 127.0.0.1. This leads to problems with multiple instances on one and the same machine. This commit integrates the ctrl interface bind option into the VTY, so that we can bind the ctrl interface to any IP address, just like we do it with the VTY already. Change-Id: If51e0c645c0789a4f4a8c51737fb81fb12f80829
2017-01-10OML: fix possible segfault: add NULL check in oml_ipa_set_attr()Philipp1-0/+2
oml_ipa_set_attr() is using gsm_objclass2mo() to determine the *mo object. However, it is possible that gsm_objclass2mo() returns a null-pointer. The code following up is using *mo without checking. Reject instead of dereferencing a NULL *mo. Fixes: coverity scan CID#159533 Change-Id: Ia2cc9bc504c46ca3843c43d712cd8649bfae9526
2017-01-10RSL: add assertions to check args of public APIPhilipp1-3/+22
The public functions in rsl.c do not check for null pointers, add assertions to catch null pointers early. Change-Id: I63f127ce70a4127180f90238f564b63e355216ec
2017-01-10RSL: drop obsolete NULL checkPhilipp1-1/+1
rsl_rx_paging_cmd() checks if the pointer *trx is NULL, this check does not make much sense since *trx has already been dereferenced without checking earlier in the code. Furthermore *trx is also a mandatory parameter which must not be NULL. Fixes: coverity scan CID#159534 Change-Id: I17dfb42ff404b2a1e18354fb7a7278089b407a79
2017-01-09VIRT-PHY: Added example configurations for openbsc and osmobts.Sebastian Stumpf3-0/+262
Change-Id: I368d4a378e20028603b09825eee766abb9195774
2017-01-08VIRT-PHY: Added functionality to cooperate with osmocom-bb virt-phy.Sebastian Stumpf28-391/+1640
This patch improves the virtual physical layer designed to replace the air interface. The purpose is to get rid of the hardware requirements and be able to start testing and implementing layer 2 communication functionality on one machine. Multicast sockets are used to enable bidirectional communication between the BTS and the MS process. The GSMTAP protocol designed for wireshark capturing is used to encapsulate the payload on the virtual physical layer. * Working mcast socket communication and extraction of its functionality. * Fixed OML and RSL startup sequences. * Icludes tests for mcast socket and virtual UM. * Ecapsulation and parsing methods to and from GSMTAP messages. * Basic handlers for file descriptor callbacks from incoming mcast messages. * Multiplexing to different channels based on GSMTAP header channel type.
2017-01-08Alarm on various errorsMax4-8/+85
Send OML Failure Report for unsupported BTS attributes and other errors. Change-Id: Ic163bcfb6361a8ebd39e0bc0f238ef51e2cb214e Related: OS#1615
2017-01-08Add Abis OML failure event reportingMax3-1/+35
Send 3GPP TS 12.21 § 8.8.2 Abis/OML failure event report. Change-Id: Ib1170edca2207752984a554d7a6a57c224f6d5f5 Related: OS#1615
2017-01-06Log socket path on errorMax1-2/+2
Change-Id: If912ac0bc815986de2a231facb5cf317a677be68
2017-01-06Move code to libosmocoreMax1-128/+7
With libosmocore commits I9c3bc15662949654e7bba6aad5488c69ee7d0c45 and Ieaaaed19da9c069fe451faa53d24c5b84d7d5615 functions to copy and merge parsed TLV were added as well as abis_nm_att_tlvdef_ipa TLV definition with related enums. Hence we can remove it from here. Change-Id: Ia4980062ea88ffe9019b201f84e92e006ae3c2e3
2017-01-06Add copyright for .deb packagesMax1-0/+81
Add debian/copyright in Debian format which should have been added in c2ecca6b0496127709dcd3afa9d366085d8bec97. Change-Id: I4c7ef1286ba6d2f3c6aadc8ea1864be513f8cf1d Related: OS#1694
2017-01-06fix: dyn ts: uplink measurement reportNeels Hofmeyr1-1/+1
Fix pchan value used for uplink measurement decisions for dynamic channels in TCH mode. Fixes this error log message flooding the osmo-bts log when a dyn ts is serving a voice call: <0004> ../../../src/common/measurement.c:104 (bts=0,trx=0,ts=3,ss=0) no space for uplink measurement Change-Id: Id19316701fd8de6f295eeae0272eea0c315ab1b7
2017-01-05WIP: Initial check-in of a new virtual BTSHarald Welte13-1/+1586
2017-01-04DTX AMR HR: fix inhibitionMax10-40/+133
* Unlike in AMR FR, in AMR HR incoming ONSET have to be treated differently depending on whether we've recently sent SID UPDATE or EMPTY frame. Split ST_SID_U FSM state into 2 states to accommodate for that and make sure that additional states specific to AMR HR are not used for AMR FR. * Avoid sending E_VOICE and E_SID_U in corresponding states as those do not initiate FSM state transitions anyway. This decrease extra load from FSM signalling which otherwise would be triggered on per-frame basis. * Introduce separate signal for SID First P1 -> P2 transition to avoid confusion with E_COMPL and E_SID_U initiated transitions from P1 state. * Don't init DTX FSM for SDCCH channels. Change-Id: I229ba39a38a223fada4881fc9aca35d3639371f8 Related: OS#1801
2016-12-22Integrate Debian packaging changesMax3-7/+29
debian/control: * restructure to make it easier to incorporate further changes * update package descriptions * update project URL debian/rules: * use proper hardening syntax * restructure to make it easier to incorporate further changes * remove useless comment * add cleanup and test overrides debian/compat: update compatibility version Change-Id: Ibf62448eee1df914d21834f5b54831e3f642b79c Related: OS#1694
2016-12-22Fix some spelling errorsRuben Undheim1-1/+1
Change-Id: I5b57102f961f8fd7fb0689ceeaa37dd021535b17
2016-12-22DTX: don't always perform AMR HR specific checkJean-Francois Dionne1-6/+8
Disable check specific to AMR HR if not DTX is enabled. Change-Id: I8af1daffbd7e59fef6e671dbd9b820497f82d354 Fixes: OS#1892
2016-12-16Optionally use adaptive RTP jitter bufferingMax4-9/+34
* add vty option to manually enable adaptive RTP jitter buffering (disabled by default) on per-bts level * use this setting on per-lchan level when setting jitter parameters via vty at runtime * check and log result of osmo_rtp_socket_set_param() * note: older libosmo-abis will ignore this setting which will be properly detected via return value * if jitter buffer is disabled by configuring "rtp jitter-buffer 0" than adaptive buffering is disabled as well but it will be used if jitter buffer is set to different value for a givel lchan via vty Change-Id: I489f3c419039f40b57c2ef0641c176478b8d3566
2016-12-15DTX: fix TS adjustment for ONSETMax1-5/+15
Previously timestamp was always adjusted according to FN difference. In case of ONSET event this causes unnecessary TS gap with subsequent speech packet. Fix this by checking Marker bit before performing adjustment. Change-Id: I9bf4b45aa990dd4014334dd846f43f793366056c Related: OS#1801
2016-12-12osmo-bts-trx: fix lchan deactivationMax1-2/+4
Use chan_nr for deactivating lchan instead of lchan->nr: chan_nr is the RSL Channel Number IE value, a bitfield aggregation of lchan type bits (cbits) and lchan number (lowest three bits). The error was introduced in 36153239bfd0b633c4d259a9de0a759f41197a2b. Change-Id: I6dd7060422ab9d18743c1ff2ab419e3e7299d74d
2016-12-09Save RTP metadata in Control BufferMax2-3/+18
Having RTP metadata is useful for debugging - save Sequence Number and Timestamp next to Marker bit from RTP header. Change-Id: I359b3bcb74fbfc071547fe2f9d837829374fe997
2016-12-08DTX: add explicit check if DTX enabledMax1-0/+3
Check explicitly if DTX is enabled for AMR before checking if SID frame repetition is optional. Change-Id: I660688d56505798cade1495c30338fd6806a3259 Related: OS#1801
2016-12-05TRX: prevent segfault upon phy initMax2-7/+13
Previously if multiply phy instances were configured but not used osmo-bts-trx would segfault. Terminate with clear error message instead so user can correct configuration. Example configuration which caused problem: ... phy 0 instance 0 instance 1 ... trx 0 phy 0 instance 0 Note the 2nd instance of phy 0 which is not used in trx later on. Change-Id: Id979506731ea92401458f1060e87aeb690901539
2016-12-02bursts test: test_pdtch: pre-init result memNeels Hofmeyr1-0/+2
Fixes: CID#57943 Change-Id: I4547f47c4150759d5c4ab790e34e91b784b03b39
2016-12-01Fix AGCH/PCH proportional allocationMax10-50/+44
Do not assume that 1 == BS_AG_BLKS_RES but take that information from SI3. Note: due to current implementation quirks we activate channels before SI3 obtained, than we deactivate channels upon receiving SI3 and activate them again. This might not be necessary once we migrate to proper OML state machines. This affects lc15 and sysmo hw. Change-Id: I11377b12680ac3b2f77f80e742b6f0af63fc9c1e Related: OS#1575
2016-12-01cosmetic: vty prompts: add space after '#'Neels Hofmeyr1-4/+4
Typically, our VTY prompts have space after the '#', but some of the osmo-bts VTY prompts don't: OsmoBTS# configure terminal OsmoBTS(config)# bts 0 OsmoBTS(bts)#gsmtap-sapi ccch Add spaces after the '#' to yield e.g. OsmoBTS(bts)# gsmtap-sapi ccch Change-Id: If0591a359e77f01abb76c4113181af7a7733ddd4
2016-12-01Remove duplicated codeMax11-21/+45
Remove lchan deactivation related code duplication to facilitate future use for dynamic CCCH re-activation. Change-Id: Id0d3b19dbfaa16d1734321a07a6eb0355bfd77c9
2016-12-01DTX DL AMR: rewrite FSM recursionMax8-137/+270
Add explicit state for recursion (sending the different payload data in response to the RTS request for same FN) and corresponding transition. Remove ST_FACCH_V as with new explicit recursion handling it becomes unreacheable. This makes it easier to maintain preemption (interruption of current procedure due to FACCH or Inhibition). This also reduces the number of possible transitions out of each state thus reducing graph's cyclomatic complexity. Change-Id: If39b68083d23a4a35f468a5d75f54eb733ebfd14