aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-04-21Bump version: 1.3.0.1-4f34 → 1.3.11.3.1Pau Espin Pedrol1-0/+7
Change-Id: I9a2b1db3d984aa8c93c661fba6a72d6b015e6ac5
2021-04-20lchan2lch_par(): fix missing default branch in switchVadim Yanitskiy4-25/+63
New channel mode values have recently been added with change [1] to 'enum gsm48_chan_mode'. The lack of default branch in lchan2lch_par() caused build failures on Jenkins: oml.c:956:2: error: enumeration value ‘GSM48_CMODE_SPEECH_V2_VAMOS’ not handled in switch [-Werror=switch] oml.c:956:2: error: enumeration value ‘GSM48_CMODE_SPEECH_V3_VAMOS’ not handled in switch [-Werror=switch] oml.c:956:2: error: enumeration value ‘GSM48_CMODE_SPEECH_V5_VAMOS’ not handled in switch [-Werror=switch] This function is duplicated in osmo-bts-{lc15,oc2g,octphy,sysmo}, so we unfortunately need to apply the same fix to all copy-pasted files. Change-Id: I557ff8cac6564d22485c101fba9212f5f0e95bb7 Related: [1] Ie0ea592da5610ae70290106d004e549cf3212a89
2021-02-23Bump version: 1.2.0.444-8777-dirty → 1.3.01.3.0Pau Espin Pedrol5-21/+491
Change-Id: I206af3596a714e5e9038b22e84ae6c20dc360e13
2021-02-20ta_control: fix Timing Advance control for SDCCH channelsVadim Yanitskiy1-5/+0
The check in lchan_ms_ta_ctrl() breaks Timing Advance control on SDCCH channels, because 'num_ul_meas' wraps and never reaches 4. Neither this check makes any sense for other channel types, because lchan_ms_ta_ctrl() is always called in the end of the measurement period. Let's drop it. Change-Id: I0b86d49ec00b38d0f309c56b2519e5d487f0b65b Fixes: If7ddf74db3abc9b9872abe620a0aeebe3327e70a Related: OS#5024
2021-02-19tests: Replace deprecated API log_set_print_filenamePau Espin Pedrol3-3/+3
Change-Id: Ifd1ee307252d19ae535d2234523036c319e4c0ec
2021-02-19tests: Explicitly drop category from logPau Espin Pedrol3-0/+6
Let's disable category here since we don't care about its formatting here. In any case, every test relying on logging output validation should always explicitly state the config to avoid issues in the future if default values change. Change-Id: I8713f4e04e92b4d7e211c499fc6e78983edfb139 Related: OS#5034
2021-02-16gsm_data: handle l1_info with structsPhilipp Maier4-17/+15
in struct gsm_lchan and also in other places l1_info is handled in its binary form. Libosmocore now offers structs to handle l1 info, so lets use those structs to get rid of all the manual decoding of l1_info. Depends: libosmocore I23c1890b89d5a0574eb05dace9f64cc59d6f6df7 Change-Id: I5eb516d7849750f3dd174d48c9f07dabf2c80515
2021-02-16GSMTAP: make remote host for Um logging configurable via VTYNeels Hofmeyr3-10/+69
So far, the only way to configure GSMTAP Um logging is to use the cmdline argument '-i'. Let's deprecate it, and add a VTY command to allow setting the remote host from configuration file. The legacy '-i' option, if provided, overrides the configuration file option, and will also appear in 'write file'. Change-Id: I17676a21c4e0c9cbc88f2c5c53a39c6c6c473ca1 Tweaked by: Vadim Yanitskiy <vyanitskiy@sysmocom.de>
2021-02-15vty: dont put a colon after vty_out in cfg_out macroPhilipp Maier1-1/+1
The cfg_out macro is used like a function in the code below its definition. This means a colon will follow after it is used. When the vty_out call in the macro already has a colon the final result will be vty_out(...);;. This works fine as long the macro is not used in one line if/else if/else constructs without curly braces {}. The compiler will interpret the double colon as two lines of code and run into an error then. Lets fix this by removing the colon from the vty_cout in the macro. Change-Id: I2c23c38ce892067add0f95f3e504a9c559e24519
2021-02-15l1sap: fix comment: sapi number is missingPhilipp Maier1-1/+1
Change-Id: I7922a5da0cd75eddfe019f3f5bd041ad911f1dd2
2021-02-15ta_control: make 'struct bts_ul_meas' parameters constVadim Yanitskiy3-10/+19
The only reason why it was not 'const' is that in lchan_new_ul_meas() we may need to overwrite 'ulm->is_sub'. This can still be done after memcpy()ing a new set of samples to the destination buffer. Change-Id: I0cabf75f8e0bf793c01225a4a8433e994c93f562 Related: OS#5024
2021-02-15ta_control: cosmetic: use correct naming for MIN/MAX constraintsVadim Yanitskiy1-4/+4
Change-Id: I112e0b51df06984e2e3f9b567d6d9897e9f9ba28
2021-02-15add support for sysmoBTS 1003 aka "1002 with GPS and PoE"Harald Welte3-1/+5
There's a minor derivative version of sysmoBTS 1002 which has built-in GPS and PoE. We call it 1003 in the EEPROM. Let's treat it identical to 1002 in the existing code base. Related: SYS#5327 Change-Id: Ia558587d36a75a1db1951d25b471b3f2e78ef4c9
2021-02-13GSMTAP: move 'struct gsmtap_inst' and masks to 'struct gsm_bts'Vadim Yanitskiy5-25/+29
Change-Id: I1c5cb8561dfdcbfd1b23ab28cf95aea7a18c7481
2021-02-13GSMTAP: fix wrong naming of per-BTS SAPI commandsVadim Yanitskiy1-10/+10
Change-Id: Ieb2d74475e4338e9dd5f3962cf14a0448de253f8
2021-02-13GSMTAP: move 'gsmtap_sapi_names' from l1sap.c to vty.cVadim Yanitskiy3-18/+17
There is no point in having it there, as VTY is the only user. Change-Id: If919bc1b2d456559ae9ff1ce5dd27d34742ee51c
2021-02-13main: cosmetic: tweak deprecation warning messagesVadim Yanitskiy1-4/+4
Change-Id: I0b87502b1af5b8ef8c235923bf966f0c76062993
2021-02-11l1sap: be sure that UL-SACCH repetition is turned offPhilipp Maier1-1/+7
At the beginning of repeated_ul_sacch_active_decision() The UL-SACCH repetition capability is tested. If no UL-SACCH repetition is enabled the function exits. However, we should also make sure that the struct member that enabled UL-SACCH repetition on the lower level is set to false as well. Normally that should be the case because it was never set to true before, but it is better to be sure. Change-Id: I76a841514eb955b93f2114470b2c80402cf6883c Related: SYS#5114
2021-02-11l1sap.c: be sure that FACCH repetition is turned offPhilipp Maier1-1/+7
At the beginning of repeated_dl_facch_active_decision() the ACCH repetition capabilitiy flags (command only or all LAPDM frames) are tested. If no FACCH repetition is enabled, the function exists. However, we should also make sure that the struct memeber that enables FACCH repetition on the lower level is set to false as well. Normally that should be the case because it was never set to true before, but it is better to be sure. Change-Id: Id07091cc89352281b41532d583a8bc004477c71a Related: SYS#5114
2021-02-11l1sap: fix repeated_dl_facch_active_decision()Philipp Maier1-1/+1
The function checks meas_res->rxqual_sub against the lower threshold value in order to decide when to turn FACCH repetition off. This is not correct. It should compare against rxqual instead. Change-Id: Id4ab101d52f419583c4f4c8a6cf69af6c9097d25 Related: SYS#5114
2021-02-10oml: ensure that IPA RSL Connect ACK/NACK contains all IEsVadim Yanitskiy1-3/+14
All IEs in the BSC originated message are optional, so we assume default values for them. Let's reflect them all in the ACK/NACK. Change-Id: I5c73e83daad0cea07b9cb674c393e0bfc6268a61 Related: OS#3791
2021-02-10oml: reuse the given msgb in oml_fom_ack_nack()Vadim Yanitskiy1-13/+13
This would allow to compose ACK/NACK messages with additional IEs not present in the original message. Also, this change basically eliminates unnecessary msgb_copy() / free(). Change-Id: I17f61636e9a144017e2c46b1540d152c21529391 Related: OS#3791
2021-02-07power_control: implement handling of P_Con_INTERVAL parameterVadim Yanitskiy10-3/+320
Change-Id: Ibf9956b2c6d829b38e9fda7d1f29790036219f42 Related: SYS#4918
2021-02-07power_control: cosmetic: fix swapped {L,U}_RXQUAL_XX_P commentsVadim Yanitskiy1-2/+2
Change-Id: I2fe198f9275f4e5407ad6fdfa68d4fa7d603e333 Related: SYS#4918
2021-02-07oml: use regular TLVP_PRES() in rx_oml_ipa_rsl_connect()Vadim Yanitskiy1-3/+3
Both NM_ATT_IPACC_DST_IP and NM_ATT_IPACC_DST_IP_PORT are defined as TLV_TYPE_FIXED, and NM_ATT_IPACC_STREAM_ID is TLV_TYPE_TV, so the TLV parser already does check the length for us. Change-Id: I1e493e552bb22bb42bb196ce71214e28d23fd19e
2021-02-07oml: make 'struct tlv_parsed' pointer const where possibleVadim Yanitskiy1-5/+5
Change-Id: I077f5aba50cc4d1a86feff527784de07394c5c0a
2021-02-07oml: avoid redundant ntohl() / htonl() conversionVadim Yanitskiy1-3/+4
Change-Id: I2ae84dcd2987ff0cee5ca06ced06e65a30847a81
2021-02-06vty: register libosmocore's FSM introspection commandsVadim Yanitskiy1-0/+1
Change-Id: I1eb203673259b455c339784719e288bac14145c0
2021-02-06oml: cosmetic code style changes in rx_oml_ipa_rsl_connect()Vadim Yanitskiy1-6/+3
Change-Id: I2841e15865596bbb24cfe1f27691404514d3b6f0
2021-02-05osmo-bts-trx/scheduler: use DMEAS in trx_sched_meas_avg()Vadim Yanitskiy1-1/+1
Change-Id: I68a37e17469ec9f8178fd2027b8860dbc643a4f9 Related: OS#5007
2021-02-04pcu_sock: fix uninitalized returncode valuePhilipp Maier1-1/+1
In function pcu_tx_si_all(), the variable rc is not initalized. If pcu_tx_si() fails, then rc is populated with value -EINVAL, but if all si transmissions succeed, which is the normal case, rc remains uninitalized. Change-Id: I571fdb4f175fb259b77f989554f569fc2230dfe6 Related: CID#216932
2021-02-04pcu_sock: pcu_tx_si_all(): fix returning ununitialized rcVadim Yanitskiy1-2/+2
Change-Id: Ic78614bebade701db14439aa64ecf89c7104a639 Fixes: CID#216932
2021-02-04pcu_sock: pcu_tx_si_all(): cosmetic coding style changeVadim Yanitskiy1-1/+2
Change-Id: I11f60ecdd3cfa2132d58fd3034bfe7419df0edb6
2021-02-04pcu_sock: pcu_tx_si_all(): make 'si_types' constVadim Yanitskiy1-1/+1
Change-Id: I0a6b0191187af2e14c9264c571afe53fc256d8ce
2021-02-03Use osmo_fd_*_{disable,enable}Harald Welte7-18/+19
Depends: libosmocore.git Idb89ba7bc7c129a6304a76900d17f47daf54d17d Change-Id: I0da17d851ccb83c28a70c9039d0a4d1fe63da0ec
2021-02-03pcu_sock: send SI1, SI3 and SI13 via PCUIFPhilipp Maier3-16/+77
This patch PCUIF extends the SAPI 4 that is used to transfer SI13 only, so that it can transfer SI1 and SI3 as well. The system information SI1, SI3 and SI13 is needed by the NACC RIM application which runs inside osmo-pcu. Depends: osmo-pcu I5138ab183793e7eee4dc494318d984e9f1f56932 Change-Id: Ib7aeb41e634ad6fcab3766a4667b0267c749436a Related: SYS#5103
2021-02-02common/measurement.c: fix gcc 4 + -std=gnu11 errorOliver Smith1-1/+1
GCC-4 doesn't like static const struct foo bar = (struct foo)...: measurement.c:33:1: error: initializer element is not constant Related: OS#5004 Change-Id: Iec5a4006dfc90abe240fcf8b6c2fefd4f7071a70
2021-01-28chan activ: activate DL SACCH only when TA is knownNeels Hofmeyr1-2/+14
A channel activation for handover to another cell does not know the Timing Advance until the handover RACH is received. It does not make much sense to enable downlink SACCH without an accurate TA. If the BSC omits the Access Delay IE (a.k.a. the Timing Advance), do not enable downlink SACCH. This is expected to happen only for inter-cell handover. In all other situations, the TA should be known either from a Channel Request RACH for Immediate Assignment, or from the previous lchan on the same cell upon Assignment / intra-cell handover. Related: OS#4008 OS#4009 SYS#5192 Change-Id: I170b63c9856230d5f1a10654a9d950ada8e730d7
2021-01-28configure.ac: set -std=gnu11Oliver Smith1-0/+2
Change-Id: I234394b2c8bec2a3920fd57bee238b99e4e60c22
2021-01-24power_control: clarify the meaning of 'delta' in logging messagesVadim Yanitskiy2-78/+78
One part of the algorithm simply provides a _suggested_ 'delta' that needs to be applied to the current power level, while the other part ensures that this suggested value does not exceed the limits. Thus it's possible that some logging messages would state that the power reduction value remains unchanged, while the 'detla' != 0. Change-Id: I7496a158b9ac6074a965056d708d8078a98cb1aa Related: SYS#4918
2021-01-23l1sap: include Uplink RSSI in GSMTAP packetsVadim Yanitskiy1-2/+5
Change-Id: I99a257c0320b08b62270a35796bee7f8e862e3ab Related: SYS#5073
2021-01-23l1sap: fix gsmtap_ph_{data,pdch,rach}(): use 'const'Vadim Yanitskiy1-6/+9
Change-Id: If353ba78b59af2b0a62bbd0c812a46990b07776f
2021-01-21power_control: add test for inc / red step size limitationsVadim Yanitskiy3-0/+189
Change-Id: Ic2d4e144b0319d86daa9fbe38727b892081f0c37 Related: SYS#4918
2021-01-20vty: add expert commands for MS/BS power controlVadim Yanitskiy1-0/+76
These new commands are useful for debugging MS/BS power control loops, e.g. one can change power control mode, overwrite the current BS power reduction or MS power level at run-time. Change-Id: I1ebb033b02c2bc3b1fa7de874e0035a07297f266 Related: SYS#4918
2021-01-20vty: make commands related to the loopback mode hiddenVadim Yanitskiy1-8/+10
The loopback mode was added for testing, and may be dangerous if enabled in production. Let's make it appear only in expert mode. Change-Id: I3f68acd7f2b0231f78516f59fb5e8ef56fb69dbf
2021-01-20vty: extend trx / lchan number range in BTS_T_T_L_CMDVadim Yanitskiy1-1/+1
Change-Id: I8d8a4c46909daa0f2682d9662db8dffb4fbd8422
2021-01-20vty: add macro for 'bts <0-0> trx <0-0> ts <0-7> lchan <0-1>'Vadim Yanitskiy1-3/+5
Change-Id: If8e1ee87366a0d301e21161f2d9ddde8383cb744
2021-01-20vty: fix error messages in lchan specific commandsVadim Yanitskiy1-3/+3
Change-Id: Ic0fba0605fc8a3ffa044f65fdad03b95e7cd8331
2021-01-20power_control: fix: properly print 'delta' applied to attenuationVadim Yanitskiy2-32/+32
Change-Id: I178df05c1a4cb982279b21d07bd69f75b44928da Related: SYS#4918
2021-01-20power_control: print current RxLev and lower/upper thresholdsVadim Yanitskiy2-60/+65
This makes the logging messages easier to read and understand. Change-Id: I5f8c987054b2b01acdb9f525d06ca15bbc577070 Related: SYS#4918
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-28 12:42:10 +0000