diff options
| author | Pau Espin Pedrol <pespin@sysmocom.de> | 2018-11-26 13:53:52 +0100 |
|---|---|---|
| committer | Pau Espin Pedrol <pespin@sysmocom.de> | 2018-11-26 14:08:14 +0100 |
| commit | e3cb8715f59cae342b6ecb96be4eb82c1ad00b4e (patch) | |
| tree | 4e8027fda24949ff6f049d8fa6fa34c67eb42d1d /tests | |
| parent | 47c8f37c9f52ce66e0dabce2d5c2567d7a5d24da (diff) | |
bts_model: Allow TS connect to be processed asynchronously
This commit doesn't change internal logic of any model, only the API to
be able to return result of connect TS asyncrhonously since some models
(like osmo-bts-trx) require some time to process the result. This way
PDCH ACT/DEACT (N)ACK can be sent once the result of this long process
is known. For instance, nowadays in osmo-bts-trx we PDCH (DE)ACT ACK
before getting the result from SETSLOT on the TRX iface.
With this new API, bts_model_ts_connect doesn't return any value
synchronously. Instead, it is expected to always end up calling
cb_ts_connected with the return code from the TS activation process. 0
is considered a successs, while any other value is considered an error.
Change-Id: Ie073a4397dd2f1a691968d12b15b8b42f1e1b0cf
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/handover/handover_test.c | 2 | ||||
| -rw-r--r-- | tests/meas/meas_test.c | 4 | ||||
| -rw-r--r-- | tests/stubs.c | 4 |
3 files changed, 5 insertions, 5 deletions
diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index 407ed95d..a805554e 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -278,6 +278,6 @@ int bts_model_trx_close(struct gsm_bts_trx *trx) { return 0; } void trx_get_hlayer1(void) {} int bts_model_adjst_ms_pwr(struct gsm_lchan *lchan) { return 0; } int bts_model_ts_disconnect(struct gsm_bts_trx_ts *ts) { return 0; } -int bts_model_ts_connect(struct gsm_bts_trx_ts *ts, enum gsm_phys_chan_config as_pchan) { return 0; } +void bts_model_ts_connect(struct gsm_bts_trx_ts *ts, enum gsm_phys_chan_config as_pchan) { return; } int bts_model_lchan_deactivate(struct gsm_lchan *lchan) { return 0; } int bts_model_lchan_deactivate_sacch(struct gsm_lchan *lchan) { return 0; } diff --git a/tests/meas/meas_test.c b/tests/meas/meas_test.c index f5803743..b2bf80e2 100644 --- a/tests/meas/meas_test.c +++ b/tests/meas/meas_test.c @@ -659,9 +659,9 @@ int bts_model_ts_disconnect(struct gsm_bts_trx_ts *ts) return 0; } -int bts_model_ts_connect(struct gsm_bts_trx_ts *ts, enum gsm_phys_chan_config as_pchan) +void bts_model_ts_connect(struct gsm_bts_trx_ts *ts, enum gsm_phys_chan_config as_pchan) { - return 0; + return; } int bts_model_lchan_deactivate(struct gsm_lchan *lchan) diff --git a/tests/stubs.c b/tests/stubs.c index d6f4d3d8..7c64034b 100644 --- a/tests/stubs.c +++ b/tests/stubs.c @@ -54,6 +54,6 @@ void bts_model_abis_close(struct gsm_bts *bts) int bts_model_ts_disconnect(struct gsm_bts_trx_ts *ts) { return 0; } -int bts_model_ts_connect(struct gsm_bts_trx_ts *ts, +void bts_model_ts_connect(struct gsm_bts_trx_ts *ts, enum gsm_phys_chan_config as_pchan) -{ return 0; } +{ return; } |