diff options
| author | Philipp Maier <pmaier@sysmocom.de> | 2020-01-15 11:01:24 +0100 |
|---|---|---|
| committer | laforge <laforge@osmocom.org> | 2020-01-20 14:33:49 +0000 |
| commit | a0403d3769d3027639e35874c09808ce5c0ba860 (patch) | |
| tree | 2cce8edf58ad8fd11864475886b5028d4d0e1570 /src/osmo-bts-trx/trx_vty.c | |
| parent | e7d835ca8c704f7cd256702a31a15b79824e21a4 (diff) | |
ta_control: move timing advance code from osmo-bts-trx to common
The timing advance controller that is implemented in loops.c of
osmo-bts-trx only works for osmo-bts-trx and not for any of the phy
based bts. Lets move the timing advance controller into the common part
and make it available for every bts. Also lets add a unit-test.
Change-Id: If7ddf74db3abc9b9872abe620a0aeebe3327e70a
Related: SYS#4567
Diffstat (limited to 'src/osmo-bts-trx/trx_vty.c')
| -rw-r--r-- | src/osmo-bts-trx/trx_vty.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c index 5c5e477c..9c67a7f0 100644 --- a/src/osmo-bts-trx/trx_vty.c +++ b/src/osmo-bts-trx/trx_vty.c @@ -181,23 +181,19 @@ DEFUN_DEPRECATED(cfg_phy_no_ms_power_loop, cfg_phy_no_ms_power_loop_cmd, return CMD_SUCCESS; } -DEFUN(cfg_phy_timing_advance_loop, cfg_phy_timing_advance_loop_cmd, +DEFUN_DEPRECATED(cfg_phy_timing_advance_loop, cfg_phy_timing_advance_loop_cmd, "osmotrx timing-advance-loop", OSMOTRX_STR "Enable timing advance control loop\n") { - struct phy_link *plink = vty->index; - - plink->u.osmotrx.trx_ta_loop = true; + vty_out (vty, "'osmotrx timing-advance-loop' is deprecated, ta control is now active by default%s", VTY_NEWLINE); return CMD_SUCCESS; } -DEFUN(cfg_phy_no_timing_advance_loop, cfg_phy_no_timing_advance_loop_cmd, +DEFUN_DEPRECATED(cfg_phy_no_timing_advance_loop, cfg_phy_no_timing_advance_loop_cmd, "no osmotrx timing-advance-loop", NO_STR OSMOTRX_STR "Disable timing advance control loop\n") { - struct phy_link *plink = vty->index; - - plink->u.osmotrx.trx_ta_loop = false; + vty_out (vty, "'no osmotrx timing-advance-loop' is deprecated, ta control is now active by default%s", VTY_NEWLINE); return CMD_SUCCESS; } @@ -522,8 +518,6 @@ void bts_model_config_write_phy(struct vty *vty, struct phy_link *plink) vty_out(vty, " osmotrx ip remote %s%s", plink->u.osmotrx.remote_ip, VTY_NEWLINE); - vty_out(vty, " %sosmotrx timing-advance-loop%s", (plink->u.osmotrx.trx_ta_loop) ? "" : "no ", VTY_NEWLINE); - if (plink->u.osmotrx.base_port_local) vty_out(vty, " osmotrx base-port local %"PRIu16"%s", plink->u.osmotrx.base_port_local, VTY_NEWLINE); |