diff options
| author | Pau Espin Pedrol <pespin@sysmocom.de> | 2023-04-03 19:13:26 +0200 |
|---|---|---|
| committer | pespin <pespin@sysmocom.de> | 2023-04-06 10:28:22 +0000 |
| commit | aebd2a21b5457a19fe79bc2fd3b54ca9eeb6c6ec (patch) | |
| tree | eaa3e18fe4593f871a17f6a0a12942cd86ec1ee9 /src/osmo-bts-octphy | |
| parent | 8c397da917725bb3c648eecc34943bd4eef91a11 (diff) | |
nm: Drop NM_EV_SETATTR_{ACK/NACK}
Simply return error codes from lower layer implementations, and do
the OML handling in the common NM TS 12.21 FSMs.
As a result, we simplify the logic in the lower layers.
Change-Id: I281c07bb5ad88ee03542f092141cebe036d10aee
Diffstat (limited to 'src/osmo-bts-octphy')
| -rw-r--r-- | src/osmo-bts-octphy/l1_oml.c | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/src/osmo-bts-octphy/l1_oml.c b/src/osmo-bts-octphy/l1_oml.c index 8ffd1ac2..6b3148ca 100644 --- a/src/osmo-bts-octphy/l1_oml.c +++ b/src/osmo-bts-octphy/l1_oml.c @@ -1742,30 +1742,20 @@ int bts_model_check_oml(struct gsm_bts *bts, uint8_t msg_type, } /* callback from OML */ -int bts_model_apply_oml(struct gsm_bts *bts, struct msgb *msg, +int bts_model_apply_oml(struct gsm_bts *bts, const struct msgb *msg, struct tlv_parsed *new_attr, int kind, void *obj) { struct abis_om_fom_hdr *foh = msgb_l3(msg); - struct gsm_abis_mo *mo = gsm_objclass2mo(bts, foh->obj_class, &foh->obj_inst); - struct nm_fsm_ev_setattr_data ev_data = { - .msg = msg, - .cause = 0, - }; - int rc; struct gsm_bts_trx *trx; switch (foh->msg_type) { case NM_MT_SET_RADIO_ATTR: trx = obj; - /*struct octphy_hdl *fl1h = trx_octphy_hdl(trx); */ power_ramp_start(trx, get_p_target_mdBm(trx, 0), 0, NULL); break; } - rc = osmo_fsm_inst_dispatch(mo->fi, - ev_data.cause == 0 ? NM_EV_SETATTR_ACK : NM_EV_SETATTR_NACK, - &ev_data); - return rc; + return 0; } |