diff options
author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2017-06-23 23:32:37 +0200 |
---|---|---|
committer | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2017-06-24 00:49:26 +0200 |
commit | 61f9158eaffd7f4be76f7a44d803d9ba14988d92 (patch) | |
tree | 31521544d6f1ecf467bf775a5e72c7e70119613e /src/common/sysinfo.c | |
parent | 1ba0cfe9c0fe8423f9d2f8676ad39c5fd53e237f (diff) |
Revert "RSL: receive and send multiple SI2q messages"
This reverts commit 340cff51f49f6e798cb5fb6d1b9febdd09902906.
osmo-gsm-tester detected a regression due to this commit, when running
osmo-bts-trx. The modems timed out when waiting for them to register with the
osmo-bts-trx network. osmo-bts-sysmo is apparently not affected. No further
details on the failure cause are known yet. The failure is shown for example by
http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_run/868/
Change-Id: I15bca30ddc09a7a3044096626016f6130d07636c
Diffstat (limited to 'src/common/sysinfo.c')
-rw-r--r-- | src/common/sysinfo.c | 16 |
1 files changed, 1 insertions, 15 deletions
diff --git a/src/common/sysinfo.c b/src/common/sysinfo.c index 9276c7bb..7a536274 100644 --- a/src/common/sysinfo.c +++ b/src/common/sysinfo.c @@ -25,16 +25,6 @@ #include <osmo-bts/logging.h> #include <osmo-bts/gsm_data.h> -/* properly increment SI2q index and return SI2q data for scheduling */ -static inline uint8_t *get_si2q_inc_index(struct gsm_bts *bts) -{ - uint8_t i = bts->si2q_index; - /* si2q_count is the max si2q_index value, not the number of messages */ - bts->si2q_index = (bts->si2q_index + 1) % (bts->si2q_count + 1); - - return (uint8_t *)GSM_BTS_SI2Q(bts, i); -} - /* Apply the rules from 05.02 6.3.1.3 Mapping of BCCH Data */ uint8_t *bts_sysinfo_get(struct gsm_bts *bts, const struct gsm_time *g_time) { @@ -109,10 +99,6 @@ uint8_t *bts_sysinfo_get(struct gsm_bts *bts, const struct gsm_time *g_time) else { /* increment static counter by one, modulo count */ btsb->si.tc4_ctr = (btsb->si.tc4_ctr + 1) % tc4_cnt; - - if (tc4_sub[btsb->si.tc4_ctr] == SYSINFO_TYPE_2quater) - return get_si2q_inc_index(bts); - return GSM_BTS_SI(bts, tc4_sub[btsb->si.tc4_ctr]); } case 5: @@ -128,7 +114,7 @@ uint8_t *bts_sysinfo_get(struct gsm_bts *bts, const struct gsm_time *g_time) else if (GSM_BTS_HAS_SI(bts, SYSINFO_TYPE_2quater) && !GSM_BTS_HAS_SI(bts, SYSINFO_TYPE_2bis) && !GSM_BTS_HAS_SI(bts, SYSINFO_TYPE_2ter)) - return get_si2q_inc_index(bts); + return GSM_BTS_SI(bts, SYSINFO_TYPE_2quater); break; case 6: return GSM_BTS_SI(bts, SYSINFO_TYPE_3); |