diff options
| author | Harald Welte <laforge@gnumonks.org> | 2019-02-09 09:24:37 +0100 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2019-02-12 20:08:18 +0100 |
| commit | ccc7ba17c014b24b1d850c9c64e4ed47629bf9a3 (patch) | |
| tree | e85af18b4fc85925f40c2dcef254fdaf2e8aece4 | |
| parent | 055c29bc6b5f29578eff9ef3211a334b302a25e6 (diff) | |
OML: Report short messages even for invalid TRX numbers in down_fom()
Change-Id: I65b57d3fc714814db3ae3fd34398f307413fece8
| -rw-r--r-- | src/common/oml.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/common/oml.c b/src/common/oml.c index ad8ab81b..96d9dd64 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -1093,12 +1093,10 @@ static int down_fom(struct gsm_bts *bts, struct msgb *msg) int ret; if (msgb_l2len(msg) < sizeof(*foh)) { - LOGP(DOML, LOGL_NOTICE, "Formatted O&M message too short\n"); trx = gsm_bts_trx_num(bts, foh->obj_inst.trx_nr); - if (trx) { - oml_tx_failure_event_rep(&trx->mo, OSMO_EVT_MAJ_UKWN_MSG, - "Formatted O&M message too short"); - } + if (trx) + mo = &trx->mo; + oml_tx_failure_event_rep(mo, OSMO_EVT_MAJ_UKWN_MSG, "Formatted O&M message too short"); return -EIO; } |