diff options
| author | Harald Welte <laforge@gnumonks.org> | 2019-05-19 16:13:51 +0200 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2019-05-21 00:31:11 +0200 |
| commit | 7240062b75540747461baf42bca5c73d879985af (patch) | |
| tree | 9e972764c0cbbf7e2a19a31379f9a1287fadfc65 | |
| parent | 1873a30a4a0a8728046bdcd22e7bc840e292a10b (diff) | |
RSL: Fix off-by-one error when parsing SACCH INFO IE in RSL CHAN ACT
This off-by-one error in length verification caused all SACCH INFO IE
to be deemed invalid and hence any RSL CHAN ACT with that IE to be
rejected.
Change-Id: I6436caf5c2caefbf7c089d66e37d8d1babe1c24e
Related: OS#3750
| -rw-r--r-- | src/common/rsl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/common/rsl.c b/src/common/rsl.c index b02f4e69..76aaef33 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1133,7 +1133,7 @@ static int rsl_rx_chan_activ(struct msgb *msg) lapdm_ui_prefix_lchan(lchan, cur, osmo_si, si_len); cur += si_len; - if (cur >= val + tot_len) { + if (cur > val + tot_len) { LOGP(DRSL, LOGL_ERROR, "Error parsing SACCH INFO IE\n"); rsl_tx_error_report(msg->trx, RSL_ERR_IE_CONTENT, &dch->chan_nr, NULL, msg); |