diff options
authorHolger Hans Peter Freyther <holger@moiji-mobile.com>2014-03-03 16:28:53 +0100
committerHolger Hans Peter Freyther <holger@moiji-mobile.com>2014-03-03 16:28:53 +0100
commite5bda88c9d7ccfdd7941ba5270701e9f5449e348 (patch)
parent5030972316892019a62423dfb9bd26ad158cda5a (diff)
sysmobts: Do not generate RF Conn failure for CCCH and PDCH
This could lead to a BSC attempting to release the BCCH or a PDCH. In the case of the BCCH this lead to a funny crash. Log: <0000> rsl.c:605 (bts=0,trx=0,ts=0,ss=4) Sending Connection Failure: cause = 0x01 <0000> rsl.c:1720 (bts=0,trx=0,ts=0,ss=0) Rx RSL DEACTIVATE_SACCH Backtrace: Program received signal SIGSEGV, Segmentation fault. msgb_dequeue (queue=0x4007d2d8) at msgb.c:102 102 llist_del(lh); (gdb) bt #0 msgb_dequeue (queue=0x4007d2d8) at msgb.c:102 #1 0x4002ed28 in lapd_dl_flush_tx (dl=0x4007d220) at lapd_core.c:173 #2 0x40030cb4 in lapd_dl_reset (dl=0x4007d220) at lapd_core.c:307 #3 0x40030d00 in lapd_dl_exit (dl=0x4007d220) at lapd_core.c:321 #4 0x40033d80 in lapdm_entity_exit (le=<optimized out>) at lapdm.c:169 #5 0x40033d9c in lapdm_channel_exit (lc=0x4007d214) at lapdm.c:180 #6 0x0001a334 in rsl_tx_rf_rel_ack (lchan=0x4007d180) at rsl.c:505 #7 0x0000e908 in lchan_deactivate_sapis (lchan=0x4007d180) at oml.c:1427 #8 sapi_queue_exeute (lchan=0x4007d180) at oml.c:547 #9 0x0000ead0 in sapi_queue_send (lchan=<optimized out>) at oml.c:571 #10 queue_sapi_command (lchan=<optimized out>, cmd=<optimized out>) at oml.c:609 #11 queue_sapi_command (lchan=0x4007d180, cmd=<optimized out>) at oml.c:601 #12 0x0000faf0 in enqueue_rel_marker (lchan=0x4007d180) at oml.c:1440 #13 lchan_deactivate (lchan=0x4007d180) at oml.c:1447 #14 0x0001004c in bts_model_rsl_chan_rel (lchan=<optimized out>) at oml.c:1647 #15 0x0001b948 in rsl_rx_rf_chan_rel (lchan=0x4007d180) at rsl.c:844 #16 rsl_rx_dchan (msg=0x75a88, trx=0x4007b038) at rsl.c:1727 #17 down_rsl (trx=0x4007b038, msg=0x75a88) at rsl.c:1853 #18 0x000154d4 in sign_link_cb (msg=<optimized out>) at abis.c:132 #19 0x400701c0 in ?? () from /usr/lib/libosmoabis.so.2 #20 0x400701c0 in ?? () from /usr/lib/libosmoabis.so.2 Backtrace stopped: previous frame identical to this frame (corrupt stack?) Fixes: OW#1133
1 files changed, 6 insertions, 0 deletions
diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index fbc259bb..ccdd79c0 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -1117,6 +1117,12 @@ static void mute_handle_ts(struct gsm_bts_trx_ts *ts, int is_muted)
if (lchan->state != LCHAN_S_ACTIVE)
+ /* skip channels that might be active for another reason */
+ if (lchan->type == GSM_LCHAN_CCCH)
+ continue;
+ if (lchan->type == GSM_LCHAN_PDTCH)
+ continue;
if (lchan->s <= 0)