aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHolger Hans Peter Freyther <holger@moiji-mobile.com>2013-07-11 10:21:39 +0200
committerHolger Hans Peter Freyther <holger@moiji-mobile.com>2013-10-06 15:51:27 +0200
commitd2065b0c843cfa283bb1685ef997d91a5286ffbd (patch)
treea3023458cb77a7f27b077cea12144881f89846c7
parentb469e7314860794aebd904ebc4a63f877c01c3fc (diff)
sysmobts: Enable the RF active LED only when enabling the carrierzecke/led-late
TODO: check at which point... there is an emission of the BTS...
-rw-r--r--src/osmo-bts-sysmo/l1_if.c3
-rw-r--r--src/osmo-bts-sysmo/oml.c5
2 files changed, 5 insertions, 3 deletions
diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index 0af1014..c4c9392 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -1019,8 +1019,7 @@ static int activate_rf_compl_cb(struct gsm_bts_trx *trx, struct msgb *resp)
LOGP(DL1C, LOGL_FATAL, "RF-ACT.conf with status %s\n",
get_value_string(femtobts_l1status_names, status));
bts_shutdown(trx->bts, "RF-ACT failure");
- } else
- sysmobts_led_set(LED_RF_ACTIVE, 1);
+ }
/* signal availability */
oml_mo_state_chg(&trx->mo, NM_OPSTATE_DISABLED, NM_AVSTATE_OK);
diff --git a/src/osmo-bts-sysmo/oml.c b/src/osmo-bts-sysmo/oml.c
index faef025..5ad618a 100644
--- a/src/osmo-bts-sysmo/oml.c
+++ b/src/osmo-bts-sysmo/oml.c
@@ -39,6 +39,7 @@
#include "l1_if.h"
#include "femtobts.h"
#include "utils.h"
+#include "hw_misc.h"
enum sapi_cmd_type {
SAPI_CMD_ACTIVATE,
@@ -235,8 +236,10 @@ static int trx_init_compl_cb(struct gsm_bts_trx *trx, struct msgb *l1_msg)
if (ic->status != GsmL1_Status_Success) {
LOGP(DL1C, LOGL_FATAL, "Rx MPH-INIT.conf status=%s\n",
get_value_string(femtobts_l1status_names, ic->status));
+ sysmobts_led_set(LED_RF_ACTIVE, 0);
bts_shutdown(trx->bts, "MPH-INIT failure");
- }
+ } else
+ sysmobts_led_set(LED_RF_ACTIVE, 1);
fl1h->hLayer1 = ic->hLayer1;