diff options
| author | Philipp <pmaier@sysmocom.de> | 2017-01-09 12:10:04 +0100 |
|---|---|---|
| committer | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2017-01-10 11:53:50 +0000 |
| commit | 792573dc9747b256e143183cb555b9ef4ca697ef (patch) | |
| tree | 8b1fe12dda1e05f6a29123ec4e2246fd6cca2bf4 | |
| parent | ec11a85929afffd46b0c3daf8979c90e992fb727 (diff) | |
RSL: drop obsolete NULL check
rsl_rx_paging_cmd() checks if the pointer *trx is NULL, this check
does not make much sense since *trx has already been dereferenced
without checking earlier in the code. Furthermore *trx is also a
mandatory parameter which must not be NULL.
Fixes: coverity scan CID#159534
Change-Id: I17dfb42ff404b2a1e18354fb7a7278089b407a79
| -rw-r--r-- | src/common/rsl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/common/rsl.c b/src/common/rsl.c index be1861cb..41dd2cea 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -402,7 +402,7 @@ static int rsl_rx_paging_cmd(struct gsm_bts_trx *trx, struct msgb *msg) identity_lv, chan_needed); if (rc < 0) { /* FIXME: notfiy the BSC on other errors? */ - if (rc == -ENOSPC && trx) + if (rc == -ENOSPC) oml_tx_failure_event_rep(&trx->mo, OSMO_EVT_MIN_PAG_TAB_FULL, "BTS paging table is full\n"); |