diff options
| author | Stefan Sperling <ssperling@sysmocom.de> | 2018-11-06 15:49:27 +0100 |
|---|---|---|
| committer | Stefan Sperling <ssperling@sysmocom.de> | 2018-11-06 15:51:05 +0100 |
| commit | e5f4654ee34c5a346a0b85805c706115464e96e1 (patch) | |
| tree | 22da790114ade505b2229f47060ef3500c5a3c51 | |
| parent | 2910b783051aa5059aeb370b164a1ee82ac3095c (diff) | |
prevent potential NULL dereference in virtbts's tx_tchh_fn
If chan_state->ongoing_facch is set, this code's logic
suggests that both msg_facch and msg_tch could be NULL.
Don't dereference msg_tch unconditionally.
Change-Id: Icf5584396c5b925d55ca9380dd4f869ae5d72da3
Related: CID#172047
| -rw-r--r-- | src/osmo-bts-virtual/scheduler_virtbts.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/osmo-bts-virtual/scheduler_virtbts.c b/src/osmo-bts-virtual/scheduler_virtbts.c index 2248afc5..25f65839 100644 --- a/src/osmo-bts-virtual/scheduler_virtbts.c +++ b/src/osmo-bts-virtual/scheduler_virtbts.c @@ -463,7 +463,7 @@ ubit_t *tx_tchh_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, if (msg_facch) { tx_to_virt_um(l1t, tn, fn, chan, msg_facch); msgb_free(msg_tch); - } else + } else if (msg_tch) tx_to_virt_um(l1t, tn, fn, chan, msg_tch); send_burst: |