diff options
| author | Pau Espin Pedrol <pespin@sysmocom.de> | 2020-09-17 16:11:14 +0200 |
|---|---|---|
| committer | pespin <pespin@sysmocom.de> | 2020-09-17 16:37:39 +0000 |
| commit | ee92f6980fe30cd73aecfbd78958ba4f4077b30b (patch) | |
| tree | 9c276c307a6223a9c672b0ce5150e6fdca34d624 | |
| parent | 0cd8df218429ee7e05d7dbcafbeabba2f26d4b98 (diff) | |
oml: Set RadioChannel operational state to Enabled only during OPSTART
Otherwise they may be set to ENABLED before CHAN SET ATTR and OPSTART
are sent, and oml_rx_opstart will blindly OPSTART ack (because they are
already enabled) and avoid configuring the timeslots.
That can happen if phy_link & rsl link get ready before receiving all
the OML CHAN SET ATTR and OPSTART commands on all RadioChannels.
Fixes: OS#4757
Change-Id: I50722c4e82faae32371817c3878bb41bfd0175ba
| -rw-r--r-- | src/common/bts_trx.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/common/bts_trx.c b/src/common/bts_trx.c index 3130372b..93e15c32 100644 --- a/src/common/bts_trx.c +++ b/src/common/bts_trx.c @@ -180,7 +180,6 @@ int trx_link_estab(struct gsm_bts_trx *trx) /* set the availability of the TRX based on internal state (RSL + phy link) */ void trx_operability_update(struct gsm_bts_trx *trx) { - int tn; enum abis_nm_op_state op_st; enum abis_nm_avail_state avail_st; struct phy_instance *pinst = trx_phy_instance(trx); @@ -192,8 +191,6 @@ void trx_operability_update(struct gsm_bts_trx *trx) LOGPTRX(trx, DSUM, LOGL_INFO, "Setting operative = %s\n", abis_nm_opstate_name(op_st)); oml_mo_state_chg(&trx->mo, op_st, avail_st); oml_mo_state_chg(&trx->bb_transc.mo, -1, avail_st); - for (tn = 0; tn < ARRAY_SIZE(trx->ts); tn++) - oml_mo_state_chg(&trx->ts[tn].mo, op_st, avail_st); } |