diff options
authorVadim Yanitskiy <axilirator@gmail.com>2019-06-03 00:12:40 +0700
committerHarald Welte <laforge@gnumonks.org>2019-06-03 15:08:11 +0000
commita52c78dd3e9d7630772888db645208a86f339f2f (patch)
parentf6b6c48c8be1307a7ca81bc3ae46ce03adb91e6c (diff)
common/bts.c: bts_supports_cm(): take care about GSM48_CMODE_SIGN
At the moment, bts_supports_cm() is only called on reception of RSL Channel MODE MODIFY from the BSC. The idea is to check whether the indicated RSL channel mode is supported by a BTS model. RSL Channel MODE MODIFY message may indicate a channel in signalling mode, i.e. GSM48_CMODE_SIGN, which has always been rejected so far. Let's assume that signalling is always supported, as there is no special BTS_FEAT_* definition to check that. This change should make BTS_Tests.TC_rsl_modify_encr pass. Change-Id: I8ea98a3eb9dc15a04f665596ee276883eb824b9a
1 files changed, 5 insertions, 0 deletions
diff --git a/src/common/bts.c b/src/common/bts.c
index 97e7a8b1..596e5e01 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -744,6 +744,11 @@ int bts_supports_cm(struct gsm_bts *bts, enum gsm_phys_chan_config pchan,
enum gsm_bts_features feature = _NUM_BTS_FEAT;
+ /* We assume that signalling support is mandatory,
+ * there is no BTS_FEAT_* definition to check that. */
+ if (cm == GSM48_CMODE_SIGN)
+ return 1;
/* Before the requested pchan/cm combination can be checked, we need to
* convert it to a feature identifier we can check */
switch (pchan) {