diff options
| author | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2021-02-15 01:57:36 +0100 |
|---|---|---|
| committer | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2021-02-20 22:46:24 +0100 |
| commit | 8777b63ef80359e349fa9a219111b4bb11ac9a11 (patch) | |
| tree | 86e5e73b7c44bf64fba4659917b2007d8cbe8e14 | |
| parent | b1571af8647ec3709cb1ab03306ac9eba2c10fc4 (diff) | |
ta_control: fix Timing Advance control for SDCCH channels
The check in lchan_ms_ta_ctrl() breaks Timing Advance control on
SDCCH channels, because 'num_ul_meas' wraps and never reaches 4.
Neither this check makes any sense for other channel types,
because lchan_ms_ta_ctrl() is always called in the end of the
measurement period. Let's drop it.
Change-Id: I0b86d49ec00b38d0f309c56b2519e5d487f0b65b
Fixes: If7ddf74db3abc9b9872abe620a0aeebe3327e70a
Related: OS#5024
| -rw-r--r-- | src/common/ta_control.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/common/ta_control.c b/src/common/ta_control.c index 5a3cbf57..ccb60e2b 100644 --- a/src/common/ta_control.c +++ b/src/common/ta_control.c @@ -33,11 +33,6 @@ void lchan_ms_ta_ctrl(struct gsm_lchan *lchan) { int16_t toa256 = lchan->meas.ms_toa256; - /* Do not perform any computation when the amount of measurement - * results is too little. */ - if (lchan->meas.num_ul_meas < 4) - return; - if (toa256 < -TOA256_9OPERCENT && lchan->rqd_ta > TA_MIN) { LOGPLCHAN(lchan, DLOOP, LOGL_INFO, "TOA is too early (%d), now lowering TA from %d to %d\n", |