aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMax <msuraev@sysmocom.de>2016-11-07 16:15:43 +0100
committerHarald Welte <laforge@gnumonks.org>2016-11-08 06:54:36 +0000
commit203ea2c209b13b66e0775168da3e127e9e7f9670 (patch)
tree78056fb57ccfbb1891d2fe79ba0f9be1c5d12b40
parent38843fbf48783ee1574b86cd9c5dcc4add6b30a8 (diff)
dtx_check.gawk: Fix false-positives in DTX check
Previously, if ONSET happened exactly at the place where next SID FIRST or UPDATE should be it was incorrectly detected as error. Similarly, continuos FACCH was misinterpreted as error. Change-Id: I43fdbceea0dbdb0833c3b1cf0fc3b825803ed30e
-rwxr-xr-xcontrib/dtx_check.gawk6
1 files changed, 3 insertions, 3 deletions
diff --git a/contrib/dtx_check.gawk b/contrib/dtx_check.gawk
index 7ac8b6d0..3a3fa26d 100755
--- a/contrib/dtx_check.gawk
+++ b/contrib/dtx_check.gawk
@@ -40,7 +40,7 @@ BEGIN {
CHK = "FAIL: " TYPE " followed by " $2 " instead of P2."
ERR++
}
- if ("OK" == CHK) { # check inter-SID distances:
+ if ("OK" == CHK && "ONSET" != $2) { # check inter-SID distances:
if ("UPDATE" == TYPE) {
if (DELTA > U_MAX) {
CHK = "FAIL: delta (" $1 - FN "fn) from previous SID UPDATE (@" FN ") too big " DELTA "ms > " U_MAX "ms."
@@ -62,8 +62,8 @@ BEGIN {
}
}
}
- if ("FACCH" == TYPE && "FIRST" != $2 && 1 == SILENCE) { # check FACCH handling
- CHK = "FAIL: incorrect silence resume after FACCH."
+ if ("FACCH" == TYPE && "FIRST" != $2 && "FACCH" != $2 && 1 == SILENCE) { # check FACCH handling
+ CHK = "FAIL: incorrect silence resume with " $2 " after FACCH."
ERR++
}
}