diff options
authorNeels Hofmeyr <nhofmeyr@sysmocom.de>2017-06-23 23:32:32 +0200
committerNeels Hofmeyr <nhofmeyr@sysmocom.de>2017-06-24 00:42:06 +0200
commit73b071b1d24f814979adcc772480ccd4abb878d1 (patch)
parent9d294c9cb1dc35abf8604cf266b7734f814527fa (diff)
Revert "RSL: check for abnormal SI2q values"
This reverts commit 186c6bac0758b6f94aa101e151664b0dea5d8975. osmo-gsm-tester detected a regression due to this commit, when running osmo-bts-trx. The modems timed out when waiting for them to register with the osmo-bts-trx network. osmo-bts-sysmo is apparently not affected. No further details on the failure cause are known yet. The failure is shown for example by http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_run/868/ Change-Id: I456e9add788393ca781213cef31b5bc3d48fd531
1 files changed, 0 insertions, 6 deletions
diff --git a/src/common/rsl.c b/src/common/rsl.c
index 187a2e70..bb05decf 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -315,12 +315,6 @@ static int rsl_rx_bcch_info(struct gsm_bts_trx *trx, struct msgb *msg)
return rsl_tx_error_report(trx, RSL_ERR_IE_CONTENT);
- if (bts->si2q_index > SI2Q_MAX_NUM || bts->si2q_count > SI2Q_MAX_NUM) {
- LOGP(DRSL, LOGL_ERROR, " Rx RSL SI2quater witn impossible parameters: index %u, count %u"
- "should be <= %u\n", bts->si2q_index, bts->si2q_count, SI2Q_MAX_NUM);
- return rsl_tx_error_report(trx, RSL_ERR_IE_CONTENT);
- }
memset(GSM_BTS_SI2Q(bts, bts->si2q_index), GSM_MACBLOCK_PADDING, sizeof(sysinfo_buf_t));
memcpy(GSM_BTS_SI2Q(bts, bts->si2q_index), TLVP_VAL(&tp, RSL_IE_FULL_BCCH_INFO), len);