aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2018-05-08 21:38:33 +0200
committerNeels Hofmeyr <neels@hofmeyr.de>2018-05-08 22:14:53 +0200
commitff7eb840ad25cb9c8227de07fc3be03b759a8925 (patch)
tree5bffc2b02a90e45a9815df5eb3081e583970f6db
parentba7ed220be8efca14970f5701b3167aaab71de64 (diff)
ip.access dyn ts: properly NACK a PDCH ACT on a still active lchan
Fixes: BTS_Tests.TC_dyn_ipa_pdch_tchf_act_pdch_act_nack Change-Id: I12816ef9953467decd9f745217135702a544c8fc
-rw-r--r--src/common/rsl.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/common/rsl.c b/src/common/rsl.c
index c3e96040..902b68f8 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2115,6 +2115,13 @@ static void rsl_rx_dyn_pdch(struct msgb *msg, bool pdch_act)
return;
}
+ if (lchan->state != LCHAN_S_NONE) {
+ LOGP(DRSL, LOGL_ERROR,
+ "%s Request to PDCH %s, but lchan is still active\n",
+ gsm_ts_and_pchan_name(ts), pdch_act? "ACT" : "DEACT");
+ rsl_tx_dyn_pdch_nack(lchan, pdch_act, RSL_ERR_NORMAL_UNSPEC);
+ }
+
ts->flags |= pdch_act? TS_F_PDCH_ACT_PENDING
: TS_F_PDCH_DEACT_PENDING;