From 6552047d44bf22c6ce6668875d7921729ec623f3 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Wed, 13 Jul 2011 14:45:21 +0200 Subject: [bsc-nat] ctrlif: use the 'err' label consistently and propagate -ENOMEM in case we have no memory --- openbsc/src/osmo-bsc_nat/bsc_nat.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'openbsc/src') diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c index 2cbb7dc0f..f39856ec1 100644 --- a/openbsc/src/osmo-bsc_nat/bsc_nat.c +++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c @@ -1195,14 +1195,12 @@ static int handle_ctrlif_msg(struct bsc_connection *bsc, struct msgb *msg) cmd = talloc_zero(bsc, struct ctrl_cmd); if (!cmd) { LOGP(DNAT, LOGL_ERROR, "OOM!\n"); - return 0; + return -ENOMEM; } cmd->type = CTRL_TYPE_ERROR; cmd->id = "err"; cmd->reply = "Failed to parse command."; - ctrl_cmd_send(&bsc->write_queue, cmd); - talloc_free(cmd); - return 0; + goto err; } if (bsc->cfg) { -- cgit v1.2.3