From f2d2fef39faebcb73570ccdab41bdfef855c7e3b Mon Sep 17 00:00:00 2001 From: Oliver Smith Date: Wed, 31 Oct 2018 10:29:51 +0100 Subject: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP Fixes: coverity scan CID#189459 Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5 --- src/osmo-bsc/bts_ipaccess_nanobts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c index 40cabb8a5..1fffd89c4 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts.c @@ -32,6 +32,7 @@ #include #include #include +#include #include #include #include @@ -494,7 +495,7 @@ static void ipaccess_sign_link_reject(const struct ipaccess_unit *dev, const str return; entry->site_id = site_id; entry->bts_id = bts_id; - strncpy(entry->ip, ip, sizeof(entry->ip)); + osmo_strlcpy(entry->ip, ip, sizeof(entry->ip)); } /* Add to beginning with current timestamp */ -- cgit v1.2.3