From bbbc12148a7255ed57acc4a5b035877d822fbebf Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Wed, 28 Nov 2018 20:19:40 +0100 Subject: bsc: timeslot_fsm: Handle and ignore tear down of lchan during PDCH DEACT lchan sends TS_EV_LCHAN_UNUSED to its parent (ts) during release time. It was experimentally found that it can happen that an lchan can be terminated while waiting for a PDCH DEACT (N)ACK response. The fsm definition actually states that this event can be received in state TS_ST_WAIT_PDCH_DEACT, but it was not handled before and as a result the process aborted due to the default switch case. Change-Id: If61493e7d5449bf2c2de9fd34cdf2410625e92ac --- src/osmo-bsc/timeslot_fsm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c index 1b77ab277..91b6b54ea 100644 --- a/src/osmo-bsc/timeslot_fsm.c +++ b/src/osmo-bsc/timeslot_fsm.c @@ -534,6 +534,10 @@ static void ts_fsm_wait_pdch_deact(struct osmo_fsm_inst *fi, uint32_t event, voi } } + case TS_EV_LCHAN_UNUSED: + /* ignored */ + return; + default: OSMO_ASSERT(false); } -- cgit v1.2.3