diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2018-08-27 21:49:18 +0200 |
|---|---|---|
| committer | Neels Hofmeyr <neels@hofmeyr.de> | 2018-08-29 02:02:10 +0200 |
| commit | 4c6d3ea5137681e1a62fd0df0e54de36242723f9 (patch) | |
| tree | e601cb43889ac0266ba2922dafff9d36aab8a5fc /src | |
| parent | 4122c15ea9bcec5c4f3262abf49292aa333551da (diff) | |
inter-BSC HO incoming: continue despite missing Classmark
3GPP mandates either Classmark Information 1 or 2 in BSSMAP Handover Request,
but an SCCPlite MSC currently tested does not pass either of them. Make this
missing IE a non-fatal error, continuing anyway should work out.
See 3GPP TS 48.008, 3.2.1.8 HANDOVER REQUEST, where it says "Classmark
Information 1 or Classmark Information 2" with note 6: "One of these two
elements is sent."
Change-Id: I34d64b028210b4df8652fee1a8830ec4a4e3ac11
Diffstat (limited to 'src')
| -rw-r--r-- | src/osmo-bsc/handover_fsm.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index c2f5c8bfe..e3e8ae115 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -424,10 +424,10 @@ static bool parse_ho_request(struct gsm_subscriber_connection *conn, const struc } memcpy(&req->classmark.classmark2, e->val, len); req->classmark.classmark2_len = len; - } else { - LOG_HO(conn, LOGL_ERROR, "Missing IE: either Classmark Information 1 or 2 required\n"); - return false; - } + } else + LOG_HO(conn, LOGL_INFO, + "Missing mandatory IE: 3GPP mandates either Classmark Information 1 or 2" + " in BSSMAP Handover Request, but neither are present. Will continue without.\n"); if (TLVP_PRESENT(tp, GSM0808_IE_AOIP_TRASP_ADDR)) { int rc; |