diff options
| author | Harald Welte <laforge@gnumonks.org> | 2018-06-14 14:25:30 +0200 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2018-06-14 14:27:21 +0200 |
| commit | cc2fb61a1639b5237d2271f2789cfbe951471d78 (patch) | |
| tree | e207608b883593a8dbed9c223c30e63cff728f1e /src | |
| parent | 3f5716ce5dd9cbf1df6ae7042eebe2e18ae8034e (diff) | |
absi_rsl: Fix segfault in rsl_rx_conn_fail()
When we receive a RSL CONN FAIL IND, it may be that this happens
before any RLL is established (and hence a lchan->conn exists),
or after the RLLs have been shut down (and hence a lchan->conn doesn't
exist anymore).
So in this function, it is not legal to unconditionally dereference
lchan->conn.
Change-Id: I6380f5d2cd9364560ce3947517c84247cf4af0d4
Closes: OS#3182
Diffstat (limited to 'src')
| -rw-r--r-- | src/osmo-bsc/abis_rsl.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 60b836d31..add439069 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1382,7 +1382,8 @@ static int rsl_rx_conn_fail(struct msgb *msg) LOGPC(DRSL, LOGL_NOTICE, "\n"); rate_ctr_inc(&lchan->ts->trx->bts->bts_ctrs->ctr[BTS_CTR_CHAN_RF_FAIL]); - osmo_fsm_inst_dispatch(lchan->conn->fi, GSCON_EV_RSL_CONN_FAIL, &cause); + if (lchan->conn) + osmo_fsm_inst_dispatch(lchan->conn->fi, GSCON_EV_RSL_CONN_FAIL, &cause); return 0; } |