diff options
author | Neels Hofmeyr <neels@hofmeyr.de> | 2020-07-10 10:41:59 +0200 |
---|---|---|
committer | laforge <laforge@osmocom.org> | 2020-07-16 12:03:19 +0000 |
commit | 954ee0a4b8a3505ac5014c4099b9b3655c872efa (patch) | |
tree | ce64b63910c8c5dc12131788f5317c91695945b6 /src/osmo-bsc/bsc_subscr_conn_fsm.c | |
parent | 9899bc9d118a966ee706af3abd8194595d915080 (diff) |
RR Release Cell selection IE: fix repeated EARFCNs encoding
3GPP 44.018 10.5.2.1e defines the EARFCNs encoded in the 'Cell selection
indicator after release of all TCH and SDCCH IE' as follows:
<Cell Selection Indicator after release of all TCH and SDCCH value part> ::=
[...]
| 011 { 1 <E-UTRAN Description : < E-UTRAN Description struct >> } ** 0
So after a 3-bit discriminator of '3' there can be multiple E-UTRAN
Descriptions, and each of them starts with a '1' bit to indicate that another
item follows. Finally there is a '0' bit to indicate the list end.
Before this patch, osmo-bsc only encoded the first '1' bit, and failed to
repeat this before each following E-UTRAN Description. Fix that by moving the
'1' encoding into the loop.
The final '0' was missing. Add it.
With these changes, adjust the size calculation in
CELL_SEL_IND_AFTER_REL_MAX_BITS to match.
Also fix CELL_SEL_IND_AFTER_REL_MAX_BYTES by using OSMO_BYTES_FOR_BITS()
instead of the inaccurate (n/8)+1.
A test for this is in I882c5e1f70bcc4833fc837a95c900ce291919cc5
(osmo-ttcn3-hacks).
Related: SYS#4871 SYS#4872
Change-Id: I59e427e4ebb1c6af99b27a15c40fed82457ac8ab
Diffstat (limited to 'src/osmo-bsc/bsc_subscr_conn_fsm.c')
0 files changed, 0 insertions, 0 deletions