diff options
| author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2017-01-13 03:12:08 +0100 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2017-01-23 11:59:01 +0000 |
| commit | 93bafb611a58293e0353320a14db298133c9d99a (patch) | |
| tree | 4ba6d276b7f5e2fda43f21b765d7cca8c6b00d5e /openbsc/src/osmo-bsc_nat | |
| parent | 59504dc80fe8c0d9a18994d82586a550c7efa341 (diff) | |
cosmetic: use osmo_strlcpy() everywhere
Shorten some code and make obvious to the reader that the string copy is done
in a safe way.
Change-Id: I900726cf06d34128db22a3d3d911ee0d1423b1bd
Diffstat (limited to 'openbsc/src/osmo-bsc_nat')
| -rw-r--r-- | openbsc/src/osmo-bsc_nat/bsc_nat_rewrite.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat_rewrite.c b/openbsc/src/osmo-bsc_nat/bsc_nat_rewrite.c index 58667fe8c..e7c387c22 100644 --- a/openbsc/src/osmo-bsc_nat/bsc_nat_rewrite.c +++ b/openbsc/src/osmo-bsc_nat/bsc_nat_rewrite.c @@ -31,6 +31,7 @@ #include <osmocom/core/linuxlist.h> #include <osmocom/core/talloc.h> +#include <osmocom/core/utils.h> #include <osmocom/gsm/gsm0808.h> #include <osmocom/gsm/ipa.h> @@ -129,15 +130,15 @@ static void update_called_number(struct gsm_mncc_number *called, { if (strncmp(chosen_number, "00", 2) == 0) { called->type = 1; - strncpy(called->number, chosen_number + 2, sizeof(called->number)); + osmo_strlcpy(called->number, chosen_number + 2, + sizeof(called->number)); } else { /* rewrite international to unknown */ if (called->type == 1) called->type = 0; - strncpy(called->number, chosen_number, sizeof(called->number)); + osmo_strlcpy(called->number, chosen_number, + sizeof(called->number)); } - - called->number[sizeof(called->number) - 1] = '\0'; } /** |