aboutsummaryrefslogtreecommitdiffstats
path: root/openbsc/src/libmsc
diff options
context:
space:
mode:
authorNeels Hofmeyr <nhofmeyr@sysmocom.de>2016-04-11 20:22:46 +0200
committerNeels Hofmeyr <nhofmeyr@sysmocom.de>2016-04-20 11:22:59 +0200
commit69d3c26e43101475202643cf48e87b9c4789348c (patch)
tree7775054e5ad60c013dd922d45254bc7705c4ac24 /openbsc/src/libmsc
parent3f18cfce85f76dcf02f49825c9fa326629c20d66 (diff)
cosmetic: debug and error logging, comment tweaks
Diffstat (limited to 'openbsc/src/libmsc')
-rw-r--r--openbsc/src/libmsc/gsm_04_11.c4
-rw-r--r--openbsc/src/libmsc/gsm_subscriber.c8
-rw-r--r--openbsc/src/libmsc/iu_cs.c1
3 files changed, 12 insertions, 1 deletions
diff --git a/openbsc/src/libmsc/gsm_04_11.c b/openbsc/src/libmsc/gsm_04_11.c
index 796f1056e..45d614a0f 100644
--- a/openbsc/src/libmsc/gsm_04_11.c
+++ b/openbsc/src/libmsc/gsm_04_11.c
@@ -985,10 +985,14 @@ int gsm411_send_sms_subscr(struct gsm_subscriber *subscr,
* if yes, send the SMS this way */
conn = connection_for_subscr(subscr);
if (conn) {
+ LOGP(DLSMS, LOGL_DEBUG, "Sending SMS via already open connection %p to %s\n",
+ conn, subscr_name(subscr));
return gsm411_send_sms(conn, sms);
}
/* if not, we have to start paging */
+ LOGP(DLSMS, LOGL_DEBUG, "Sending SMS: no connection open, start paging %s\n",
+ subscr_name(subscr));
res = subscr_request_channel(subscr, RSL_CHANNEED_SDCCH,
paging_cb_send_sms, sms);
if (!res) {
diff --git a/openbsc/src/libmsc/gsm_subscriber.c b/openbsc/src/libmsc/gsm_subscriber.c
index 39b544b90..2fd9932e5 100644
--- a/openbsc/src/libmsc/gsm_subscriber.c
+++ b/openbsc/src/libmsc/gsm_subscriber.c
@@ -188,7 +188,7 @@ struct subscr_request *subscr_request_channel(struct gsm_subscriber *subscr,
/* Start paging.. we know it is async so we can do it before */
if (!subscr->is_paging) {
- LOGP(DMM, LOGL_DEBUG, "Subscriber %s not paged yet.\n",
+ LOGP(DMM, LOGL_DEBUG, "Subscriber %s not paged yet, start paging.\n",
subscr_name(subscr));
rc = msc_paging_request(subscr->group->net, subscr, channel_type,
subscr_paging_cb, subscr);
@@ -200,6 +200,12 @@ struct subscr_request *subscr_request_channel(struct gsm_subscriber *subscr,
/* reduced on the first paging callback */
subscr_get(subscr);
subscr->is_paging = 1;
+ LOGP(DMM, LOGL_DEBUG, "Paged subscriber %s.\n",
+ subscr_name(subscr));
+ }
+ else {
+ LOGP(DMM, LOGL_DEBUG, "Subscriber %s already paged.\n",
+ subscr_name(subscr));
}
/* TODO: Stop paging in case of memory allocation failure */
diff --git a/openbsc/src/libmsc/iu_cs.c b/openbsc/src/libmsc/iu_cs.c
index 863a67893..391e577f1 100644
--- a/openbsc/src/libmsc/iu_cs.c
+++ b/openbsc/src/libmsc/iu_cs.c
@@ -60,6 +60,7 @@ static inline void log_subscribers(struct gsm_network *network)
break;
case IFACE_A:
DEBUGPC(DIUCS, " A");
+ /* TODO log A-interface connection details */
break;
case IFACE_UNKNOWN:
DEBUGPC(DIUCS, " ?");