aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Welte <laforge@osmocom.org>2021-02-06 12:57:52 +0100
committerlaforge <laforge@osmocom.org>2021-02-08 17:21:20 +0000
commitc72c853a96feafaa14fd74c5ba635a73885e7382 (patch)
treede0248942337d5d2f23716e2be4c6917c7139ef5
parentea8d6939e6dc6f3a2c235c45ce63ae4cd5d9009f (diff)
hide the "smscb-command" vty command; people should use osmo-cbc
Many years prior to the implementation of osmo-cbc, we introduced a way how raw RSL SMSCB COMMANMD can be injected from the VTY. These days, people should use the CBSP interface with osmo-cbc or any other CBC. We should not advertise the VTY command hack as a standard feature anymore. Change-Id: If5ddc3db989763a1f47d4cbc026e293e3134d8ef Related: OS#4753
-rw-r--r--src/osmo-bsc/bsc_vty.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 26941e209..9005aab99 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -5796,8 +5796,9 @@ DEFUN(bts_resend_power_ctrl_params,
return CMD_SUCCESS;
}
-
-DEFUN(smscb_cmd, smscb_cmd_cmd,
+/* this command is now hidden, as it's a low-level debug hack, and people should
+ * instead use osmo-cbc these days */
+DEFUN_HIDDEN(smscb_cmd, smscb_cmd_cmd,
"bts <0-255> smscb-command (normal|schedule|default) <1-4> HEXSTRING",
"BTS related commands\n" BTS_NR_STR
"SMS Cell Broadcast\n"
@@ -5861,6 +5862,7 @@ DEFUN(smscb_cmd, smscb_cmd_cmd,
return CMD_WARNING;
}
+ /* SDCCH4 might not be correct here if the CBCH is on a SDCCH8? */
rsl_sms_cb_command(bts, RSL_CHAN_SDCCH4_ACCH, cb_cmd, false, buf, rc);
return CMD_SUCCESS;