aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Willmann <daniel@totalueberwachung.de>2011-07-16 21:50:13 +0200
committerHolger Hans Peter Freyther <zecke@selfish.org>2011-07-19 20:07:20 +0200
commit6d718c054ad2bce52548bcac1def61085a15391c (patch)
tree2010348ed446eef660ac84230bf39733158227b7
parent44fb151c12e53672002670eea9d6475f27f6b22c (diff)
osmo-bsc: Improve return handling in verify_net_loc
-rw-r--r--openbsc/src/osmo-bsc/osmo_bsc_main.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/openbsc/src/osmo-bsc/osmo_bsc_main.c b/openbsc/src/osmo-bsc/osmo_bsc_main.c
index 3a2306c94..1b914688e 100644
--- a/openbsc/src/osmo-bsc/osmo_bsc_main.c
+++ b/openbsc/src/osmo-bsc/osmo_bsc_main.c
@@ -220,7 +220,6 @@ oom:
int verify_net_loc(struct ctrl_cmd *cmd, const char *value, void *data)
{
char *saveptr, *latstr, *lonstr, *heightstr, *agestr, *tmp;
- int ret = 0;
unsigned long age;
double lat, lon, height;
@@ -235,7 +234,7 @@ int verify_net_loc(struct ctrl_cmd *cmd, const char *value, void *data)
if ((agestr == NULL) || (latstr == NULL) ||
(lonstr == NULL) || (heightstr == NULL))
- ret = 1;
+ return 1;
age = atol(agestr);
lat = atof(latstr);
@@ -246,7 +245,7 @@ int verify_net_loc(struct ctrl_cmd *cmd, const char *value, void *data)
if ((age == 0) || (lat < -90) || (lat > 90) || (lon < -180) || (lon > 180))
return 1;
- return ret;
+ return 0;
}
CTRL_CMD_DEFINE(trx_rf_lock, "rf_locked");