aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHolger Hans Peter Freyther <holger@moiji-mobile.com>2015-02-08 09:21:04 +0100
committerHolger Hans Peter Freyther <holger@moiji-mobile.com>2015-02-08 09:21:04 +0100
commit019851a5238e95dd1a089d19d966973b5a61f568 (patch)
treecc2527883f1becf37735af31aa26b6de59f84657
parent56e1766dba1a03e304e51d079e65406542e7887c (diff)
smpp: Do not check conn for being null
We are deferencing conn earlier in this function without doing a null check. At the time deliver_to_esme is called the conn will always exist and even the lchan is likely to be present. Remove the null check for conn right now. Fixes: Coverity CID 1210594
-rw-r--r--openbsc/src/libmsc/smpp_openbsc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/openbsc/src/libmsc/smpp_openbsc.c b/openbsc/src/libmsc/smpp_openbsc.c
index 6861317..ff5ab40 100644
--- a/openbsc/src/libmsc/smpp_openbsc.c
+++ b/openbsc/src/libmsc/smpp_openbsc.c
@@ -530,7 +530,7 @@ static int deliver_to_esme(struct osmo_esme *esme, struct gsm_sms *sms,
memcpy(deliver.short_message, sms->user_data, deliver.sm_length);
}
- if (esme->acl && esme->acl->osmocom_ext && conn && conn->lchan)
+ if (esme->acl && esme->acl->osmocom_ext && conn->lchan)
append_osmo_tlvs(&deliver.tlv, conn->lchan);
return smpp_tx_deliver(esme, &deliver);