diff options
| author | Holger Hans Peter Freyther <zecke@selfish.org> | 2010-08-05 10:53:26 +0000 |
|---|---|---|
| committer | Holger Hans Peter Freyther <zecke@selfish.org> | 2010-08-08 07:23:08 +0800 |
| commit | 636c1cadd8e80c8c9f5c991d1668336092931317 (patch) | |
| tree | 43e303e4c83e13ef02929633d07760b7c8932fe9 | |
| parent | 20f3d21665539a9bac4290a0595393264db40829 (diff) | |
mgcp: Be more strict on the source addr/source port of the bts
Once we have discovered the bts we will not accept data from
anything else. The call will drop if the BTS is changing the
ip address of the nat anyway.
| -rw-r--r-- | openbsc/src/mgcp/mgcp_network.c | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/openbsc/src/mgcp/mgcp_network.c b/openbsc/src/mgcp/mgcp_network.c index b7f4ee1ac..735defadd 100644 --- a/openbsc/src/mgcp/mgcp_network.c +++ b/openbsc/src/mgcp/mgcp_network.c @@ -285,6 +285,21 @@ static int rtp_data_bts(struct bsc_fd *fd, unsigned int what) inet_ntoa(addr.sin_addr)); } + if (memcmp(&endp->bts_end.addr, &addr.sin_addr, sizeof(addr.sin_addr)) != 0) { + LOGP(DMGCP, LOGL_ERROR, + "Data from wrong bts %s on 0x%x\n", + inet_ntoa(addr.sin_addr), ENDPOINT_NUMBER(endp)); + return -1; + } + + if (endp->bts_end.rtp_port != addr.sin_port && + endp->bts_end.rtcp_port != addr.sin_port) { + LOGP(DMGCP, LOGL_ERROR, + "Data from wrong bts source port %d on 0x%x\n", + ntohs(addr.sin_port), ENDPOINT_NUMBER(endp)); + return -1; + } + /* throw away the dummy message */ if (rc == 1 && buf[0] == DUMMY_LOAD) { LOGP(DMGCP, LOGL_NOTICE, "Filtered dummy from bts on 0x%x\n", |