aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2018-10-03 19:39:07 +0200
committerPau Espin Pedrol <pespin@sysmocom.de>2018-10-03 19:39:10 +0200
commitba68fe40bf193d105c3216ca5981ef8388573052 (patch)
tree27a527d6af084055a6c7637cc8beba27c4d56505
parenta82fc599b79ef8f6d673902943a2f4031130f7cf (diff)
osmo-bsc: Add default case for switch(enum)
After commit https://gerrit.osmocom.org/#/c/libosmo-abis/+/11207/ (Iaa33b793f89f2d16c9d949503c5ecc195bbcd2a4), input_signal_data->link_type exposes proper enum type, and compiler can warn about missing cases: osmo-bsc/bts_ericsson_rbs2000.c: In function ‘inp_sig_cb’: osmo-bsc/bts_ericsson_rbs2000.c:124:3: error: enumeration value ‘E1INP_SIGN_NONE’ not handled in switch [-Werror=switch] switch (isd->link_type) { ^~~~~~ Change-Id: Ia407a5072896377b68e914e2a05b5e01292ee8ee
-rw-r--r--src/osmo-bsc/bts_ericsson_rbs2000.c2
-rw-r--r--src/osmo-bsc/bts_nokia_site.c2
-rw-r--r--src/osmo-bsc/bts_siemens_bs11.c2
3 files changed, 6 insertions, 0 deletions
diff --git a/src/osmo-bsc/bts_ericsson_rbs2000.c b/src/osmo-bsc/bts_ericsson_rbs2000.c
index ed3db939a..4d1e91b0f 100644
--- a/src/osmo-bsc/bts_ericsson_rbs2000.c
+++ b/src/osmo-bsc/bts_ericsson_rbs2000.c
@@ -130,6 +130,8 @@ static int inp_sig_cb(unsigned int subsys, unsigned int signal,
else
bootstrap_om_trx(isd->trx);
break;
+ default:
+ break;
}
break;
case S_L_INP_TEI_DN:
diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c
index 052741ed1..66972c2b5 100644
--- a/src/osmo-bsc/bts_nokia_site.c
+++ b/src/osmo-bsc/bts_nokia_site.c
@@ -168,6 +168,8 @@ static int inp_sig_cb(unsigned int subsys, unsigned int signal,
else
bootstrap_om_trx(isd->trx);
break;
+ default:
+ break;
}
break;
case S_L_INP_TEI_UNKNOWN:
diff --git a/src/osmo-bsc/bts_siemens_bs11.c b/src/osmo-bsc/bts_siemens_bs11.c
index 78a87e5c6..2cb676c93 100644
--- a/src/osmo-bsc/bts_siemens_bs11.c
+++ b/src/osmo-bsc/bts_siemens_bs11.c
@@ -579,6 +579,8 @@ static int inp_sig_cb(unsigned int subsys, unsigned int signal,
if (isd->trx->bts->type == GSM_BTS_TYPE_BS11)
bootstrap_om_bs11(isd->trx->bts);
break;
+ default:
+ break;
}
}