diff options
| author | Harald Welte <laforge@gnumonks.org> | 2018-10-21 13:37:59 +0200 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2018-10-21 12:19:35 +0000 |
| commit | 60f08b57efcf0cb0747079cc04c4765a1ad27cdc (patch) | |
| tree | c245fb74ba9b3221572dd461e9786b554f647390 | |
| parent | b1f66fe1069daf5b394cf0814550c90a6eab5d1e (diff) | |
ipaccess-config: Fix open() return value checking
open() returning 0 is valid, but negative values indicate errors.
Change-Id: Id7e62116bfee550ef9906e78a0fce6f28af27a97
Fixes: Coverity CID#57865
| -rw-r--r-- | src/ipaccess/ipaccess-config.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 079bae2b9..549170095 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -634,7 +634,7 @@ static int find_sw_load_params(const char *filename) INIT_LLIST_HEAD(entry); fd = open(filename, O_RDONLY); - if (!fd) { + if (fd < 0) { perror("nada"); return -1; } @@ -729,7 +729,7 @@ static void analyze_firmware(const char *filename) printf("Opening possible firmware '%s'\n", filename); fd = open(filename, O_RDONLY); - if (!fd) { + if (fd < 0) { perror("nada"); return; } |