aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2018-02-15 14:18:22 +0100
committerNeels Hofmeyr <neels@hofmeyr.de>2018-02-16 16:11:16 +0100
commit063868e1e6cce20e5c1bf4b0dd89e4c5d64b9e07 (patch)
tree06364326bc1ba036a6ec0cd2678a8f96a22318fa
parentf802f7fd7aec1d91084231a80bbce6f2ed7bd299 (diff)
handover_logic.c: always do inter-cell channel activation
In commit [1], the channel activation kind was modified out-of-context to use Immediate Assignment in case of intra-cell re-assignment. This so far hasn't worked out in tests, so instead stay with the strategy to use RSL_ACT_INTER_ASYNC also for re-assignment within the same cell. We may move to RSL_ACT_INTRA_IMM_ASS in a separate patch after proper testing. [1]: 5eaa4fb821751b70ad2b864d8765ff96bd301996, I2d91765c1f9719c64fd99426a872cecc724215db "HO: add indicators for inter-cell and async ho, use for chan act type", Note that so far, no re-assignment within cells is triggered by the current handover decision algorithm, so the effect will be really noticeable with handover decision 2 that is coming up. See feature OS#2949 which asks for implementing actual RR Assignment to handover within a cell. Related: OS#2949 Change-Id: Ia3d979094fa16620f1acc5933418797829710ba8
-rw-r--r--src/libbsc/handover_logic.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/libbsc/handover_logic.c b/src/libbsc/handover_logic.c
index 6eada5b96..fda28dd73 100644
--- a/src/libbsc/handover_logic.c
+++ b/src/libbsc/handover_logic.c
@@ -147,9 +147,7 @@ int bsc_handover_start(struct gsm_lchan *old_lchan, struct gsm_bts *bts)
/* FIXME: do we have a better idea of the timing advance? */
rc = rsl_chan_activate_lchan(new_lchan,
- ho->inter_cell
- ? (ho->async ? RSL_ACT_INTER_ASYNC : RSL_ACT_INTER_SYNC)
- : RSL_ACT_INTRA_IMM_ASS,
+ ho->async ? RSL_ACT_INTER_ASYNC : RSL_ACT_INTER_SYNC,
ho->ho_ref);
if (rc < 0) {
LOGP(DHO, LOGL_ERROR, "could not activate channel\n");