diff options
authorPau Espin Pedrol <pespin@sysmocom.de>2018-11-28 16:53:39 +0100
committerPau Espin Pedrol <pespin@sysmocom.de>2018-12-05 16:06:47 +0000
commit0502a0ee1b06556b412f3d9796dcae22fb38da6b (patch)
parent746dbc9fdd05747ce5cc0cb4a94c1db1728053e1 (diff)
bsc: timelost_fsm: Remove unneeded set of out variable on failure
Documentation of the function explicitly states that the out target_pchan param returns the "PCHAN waited for". If we return false, then no PCHAN is being waited for. The 2 callers of this function only use this out param if function returns true, so let's simplify the code. Change-Id: Ib8f9b7e1f584dee885d6823dc043682577572bd8
1 files changed, 0 insertions, 3 deletions
diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c
index 113ec361c..145049154 100644
--- a/src/osmo-bsc/timeslot_fsm.c
+++ b/src/osmo-bsc/timeslot_fsm.c
@@ -864,9 +864,6 @@ bool ts_is_lchan_waiting_for_pchan(struct gsm_bts_trx_ts *ts, enum gsm_phys_chan
return true;
- if (target_pchan)
- *target_pchan = ts->pchan_is;
return false;