diff options
| author | Philipp Maier <pmaier@sysmocom.de> | 2023-03-09 14:41:53 +0100 |
|---|---|---|
| committer | dexter <pmaier@sysmocom.de> | 2023-03-20 09:42:05 +0000 |
| commit | ec7842f816d95ea827488b91d5bbbe41c1c9bb41 (patch) | |
| tree | 37782281694c4da512f19592d9aa980e6b262101 | |
| parent | c4ab9405443546c730f11d298193e4fc50f65998 (diff) | |
pcu_sock: check BTS type properly in pcu_info_update()
When updating the BTS information in the bsc co-located PCU, first check
if the BTS has a BSC co-located PCU at all. Also check if the BTS is E1
based since those type of BTS require extra information about the E1
connection.
Related: OS#5198
Change-Id: I8da26debc0e27f24fae4ee88f22f8875de13bc84
| -rw-r--r-- | src/osmo-bsc/pcu_sock.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index 453d5a7b7..2d77efb63 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -362,13 +362,13 @@ static int pcu_tx_e1_ccu_ind(struct gsm_bts *bts) __attribute__((weak)) void pcu_info_update(struct gsm_bts *bts) { if (pcu_connected(bts)) { - /* In cases where the CCU is connected via an E1 line, we transmit the connection parameters for the - * PDCH before we announce the other BTS related parameters. At the moment Ericsson RBS is the only - * E1 BTS we support. */ - if (is_ericsson_bts(bts)) - pcu_tx_e1_ccu_ind(bts); - - pcu_tx_info_ind(bts); + if (bsc_co_located_pcu(bts)) { + /* In cases where the CCU is connected via an E1 line, we transmit the connection parameters for the + * PDCH before we announce the other BTS related parameters. */ + if (is_e1_bts(bts)) + pcu_tx_e1_ccu_ind(bts); + pcu_tx_info_ind(bts); + } } } |