diff options
| author | arehbein <arehbein@sysmocom.de> | 2023-03-18 23:54:13 +0100 |
|---|---|---|
| committer | laforge <laforge@osmocom.org> | 2023-03-21 20:16:15 +0000 |
| commit | d7b277ff0137a48553bd660b5e51ac094f854cdd (patch) | |
| tree | e9997e407af33bf0d6b2e82e58c3d0241f0ccb6f | |
| parent | 64c0e6e11ce81dcaf01c836241f64aa96192d572 (diff) | |
gsm_bts_check_ny1: Prevent possible division by zero
Do this by setting the minimal value for T3105 to 1 in its timer definition.
Fixes: Coverity scan CID#307389
Change-Id: I1fd0b92ab507a58fed6e9649eaa4770f1ad1cbad
| -rw-r--r-- | src/osmo-bsc/net_init.c | 2 | ||||
| -rw-r--r-- | tests/timer.vty | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c index 5a7422c62..d97fd0167 100644 --- a/src/osmo-bsc/net_init.c +++ b/src/osmo-bsc/net_init.c @@ -36,7 +36,7 @@ static struct osmo_tdef gsm_network_T_defs[] = { { .T = 101, .default_val = 10, .desc = "inter-BSC/MSC Handover incoming, BSSMAP HO Request to HO Accept" }, { .T = 3101, .default_val = 3, .desc = "RR Immediate Assignment" }, { .T = 3103, .default_val = 5, .desc = "Handover" }, - { .T = 3105, .default_val = GSM_T3105_DEFAULT, .unit = OSMO_TDEF_MS, .desc = "Physical Information" }, + { .T = 3105, .default_val = GSM_T3105_DEFAULT, .min_val = 1, .unit = OSMO_TDEF_MS, .desc = "Physical Information" }, { .T = 3107, .default_val = 5, .desc = "(unused)" }, { .T = 3109, .default_val = 5, .desc = "RSL SACCH deactivation" }, { .T = 3111, .default_val = 2, .desc = "Wait time before RSL RF Channel Release" }, diff --git a/tests/timer.vty b/tests/timer.vty index 6d6efe824..e41805412 100644 --- a/tests/timer.vty +++ b/tests/timer.vty @@ -8,7 +8,7 @@ net: T10 = 6 s RR Assignment (default: 6 s) net: T101 = 10 s inter-BSC/MSC Handover incoming, BSSMAP HO Request to HO Accept (default: 10 s) net: T3101 = 3 s RR Immediate Assignment (default: 3 s) net: T3103 = 5 s Handover (default: 5 s) -net: T3105 = 100 ms Physical Information (default: 100 ms) +net: T3105 = 100 ms Physical Information (default: 100 ms, range: [1 .. inf]) net: T3107 = 5 s (unused) (default: 5 s) net: T3109 = 5 s RSL SACCH deactivation (default: 5 s) net: T3111 = 2 s Wait time before RSL RF Channel Release (default: 2 s) @@ -64,7 +64,7 @@ net: T10 = 6 s RR Assignment (default: 6 s) net: T101 = 10 s inter-BSC/MSC Handover incoming, BSSMAP HO Request to HO Accept (default: 10 s) net: T3101 = 3 s RR Immediate Assignment (default: 3 s) net: T3103 = 5 s Handover (default: 5 s) -net: T3105 = 100 ms Physical Information (default: 100 ms) +net: T3105 = 100 ms Physical Information (default: 100 ms, range: [1 .. inf]) net: T3107 = 5 s (unused) (default: 5 s) net: T3109 = 5 s RSL SACCH deactivation (default: 5 s) net: T3111 = 2 s Wait time before RSL RF Channel Release (default: 2 s) |