diff options
| author | Matan Perelman <matan1008@gmail.com> | 2024-01-04 17:39:27 +0200 |
|---|---|---|
| committer | Matan Perelman <matan1008@gmail.com> | 2024-01-04 18:14:33 +0200 |
| commit | c37fcff9c5ebbbc1be872ba20b86e302aaca0dcc (patch) | |
| tree | 865069ed86a11023bc7953f8e2e8cb9e93ea9645 | |
| parent | 29389bd44a9fc51ab70ab1634f563d2155c69f02 (diff) | |
vty: Ensure radio-link-timeout is a multiple of 4
According to Table 10.5.2.3.1 in TS 144.018, radio-link-timeout
values are between 4 to 64 in steps of 4.
Change-Id: I733591d5f72f2e4f822761ca9eda85de7a4c6c81
| -rw-r--r-- | src/osmo-bsc/bts_vty.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index ef8b8bdc4..54eb5cff6 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -1481,8 +1481,15 @@ DEFUN_USRATTR(cfg_bts_radio_link_timeout, "Radio link timeout value (lost SACCH block)\n") { struct gsm_bts *bts = vty->index; + unsigned int radio_link_timeout = atoi(argv[0]); - gsm_bts_set_radio_link_timeout(bts, atoi(argv[0])); + /* According to Table 10.5.2.3.1 in TS 144.018 */ + if (radio_link_timeout % 4 != 0) { + vty_out(vty, "%% Radio link timeout must be a multiple of 4%s", VTY_NEWLINE); + return CMD_WARNING; + } + + gsm_bts_set_radio_link_timeout(bts, radio_link_timeout); return CMD_SUCCESS; } |