aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOliver Smith <osmith@sysmocom.de>2022-05-03 16:09:39 +0200
committerlaforge <laforge@osmocom.org>2022-05-13 06:29:14 +0000
commit49dd5cfeebf2426849b22047ea3aea1a91441061 (patch)
tree63aba30f117712cc685add9d12826065f709ef1a
parentd8017c3533c459e684f2ff47d954c20bfd26c90b (diff)
abis_nm: run gsm_bts_check_cfg during oml bring up
Don't wait until RSL link goes up to check the reported features against the config. Do it in the OML bring up right after the features are reported. Related: SYS#5922, OS#5538 Change-Id: I6b1b4ef3e163528ed186050d848ec089a4315a7c
-rw-r--r--src/osmo-bsc/abis_nm.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index cdb1fa663..a460f3e3b 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -719,6 +719,12 @@ static int abis_nm_rx_get_attr_resp(struct msgb *mb)
else
rc = parse_attr_resp_info_attr(bts, trx, foh, &tp);
+ if (gsm_bts_check_cfg(bts) != 0) {
+ LOGP(DLINP, LOGL_ERROR, "(bts=%u) BTS config invalid, dropping BTS!\n", bts->nr);
+ ipaccess_drop_oml_deferred(bts);
+ return -EINVAL;
+ }
+
osmo_signal_dispatch(SS_NM, S_NM_GET_ATTR_REP, mb);
return rc;