diff options
| author | Pau Espin Pedrol <pespin@sysmocom.de> | 2019-05-23 16:32:19 +0200 |
|---|---|---|
| committer | Pau Espin Pedrol <pespin@sysmocom.de> | 2019-05-23 16:32:22 +0200 |
| commit | 46b1c81c19471f2ba280cce96fbf758fcd79a981 (patch) | |
| tree | 5907a9307e6e767387411d84dd3f830b5b6aca9d | |
| parent | 6de754cdde5319af3059d8fc6abf85037ec7eacc (diff) | |
lcls: Fix MDCX with garbage on LCLS loop break
Commit c997ceb750a67baef1a05590febe1c678b287d8f which added initial code
did use memset(0) on the structure. However, later commit
b407a8aca45ba8f3426003c4960ca8bd5cfe60e5 modifying the code forgot to
initialize it, and as a result most of its fields contain garbage.
This results in an MDCX with strange/incorrect values sent when LCLS
loop breaks, breaking TTCN3 test BSC_Tests_LCLS.TC_lcls_connect_break.
Change-Id: Ib1a7d825690db782a5d14f2d8817acf6cb6a52ea
| -rw-r--r-- | src/osmo-bsc/osmo_bsc_lcls.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c index a01c02e10..f0c62a195 100644 --- a/src/osmo-bsc/osmo_bsc_lcls.c +++ b/src/osmo-bsc/osmo_bsc_lcls.c @@ -283,7 +283,7 @@ static inline void lcls_mdcx(const struct gsm_subscriber_connection *conn, struc static void lcls_break_local_switching(struct gsm_subscriber_connection *conn) { - struct mgcp_conn_peer mdcx_info; + struct mgcp_conn_peer mdcx_info = {}; LOGPFSM(conn->lcls.fi, "=== HERE IS WHERE WE DISABLE LCLS(%s)\n", bsc_lcls_mode_name(conn->sccp.msc->lcls_mode)); |