aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMax <msuraev@sysmocom.de>2017-09-23 14:42:35 +0200
committerMax <msuraev@sysmocom.de>2017-09-25 08:27:23 +0000
commita9594b5058dc5a62ea813e7b577951e53e848ffc (patch)
treed83fe55a801707082eb6ba6bc523674d142065a3
parent9cc704424a468cf628551354d07250f6b5710ca1 (diff)
CTRL: cleanup write-only command functions
Remove trivial functions by using more specific defines for CTRL commands. Change-Id: I10d6d18663aed87324d60472a0fc3bd1d0961dea
-rw-r--r--src/osmo-bsc/osmo_bsc_ctrl.c34
1 files changed, 3 insertions, 31 deletions
diff --git a/src/osmo-bsc/osmo_bsc_ctrl.c b/src/osmo-bsc/osmo_bsc_ctrl.c
index 2446312c4..633089247 100644
--- a/src/osmo-bsc/osmo_bsc_ctrl.c
+++ b/src/osmo-bsc/osmo_bsc_ctrl.c
@@ -466,13 +466,7 @@ err:
return 1;
}
-CTRL_CMD_DEFINE(net_notification, "notification");
-static int get_net_notification(struct ctrl_cmd *cmd, void *data)
-{
- cmd->reply = "There is nothing to read";
- return CTRL_CMD_ERROR;
-}
-
+CTRL_CMD_DEFINE_WO_NOVRF(net_notification, "notification");
static int set_net_notification(struct ctrl_cmd *cmd, void *data)
{
struct ctrl_cmd *trap;
@@ -502,18 +496,7 @@ handled:
return CTRL_CMD_HANDLED;
}
-static int verify_net_notification(struct ctrl_cmd *cmd, const char *value, void *data)
-{
- return 0;
-}
-
-CTRL_CMD_DEFINE(net_inform_msc, "inform-msc-v1");
-static int get_net_inform_msc(struct ctrl_cmd *cmd, void *data)
-{
- cmd->reply = "There is nothing to read";
- return CTRL_CMD_ERROR;
-}
-
+CTRL_CMD_DEFINE_WO_NOVRF(net_inform_msc, "inform-msc-v1");
static int set_net_inform_msc(struct ctrl_cmd *cmd, void *data)
{
struct gsm_network *net;
@@ -540,18 +523,7 @@ static int set_net_inform_msc(struct ctrl_cmd *cmd, void *data)
return CTRL_CMD_HANDLED;
}
-static int verify_net_inform_msc(struct ctrl_cmd *cmd, const char *value, void *data)
-{
- return 0;
-}
-
-CTRL_CMD_DEFINE(net_ussd_notify, "ussd-notify-v1");
-static int get_net_ussd_notify(struct ctrl_cmd *cmd, void *data)
-{
- cmd->reply = "There is nothing to read";
- return CTRL_CMD_ERROR;
-}
-
+CTRL_CMD_DEFINE_WO(net_ussd_notify, "ussd-notify-v1");
static int set_net_ussd_notify(struct ctrl_cmd *cmd, void *data)
{
struct gsm_subscriber_connection *conn;