From 746179370c89589ce9a4e959740a8f551a27d935 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Mon, 12 Oct 2015 14:26:49 +0200 Subject: gtp.c: add todo comments Sponsored-by: On-Waves ehi --- gtp/gtp.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gtp/gtp.c b/gtp/gtp.c index 73ed76a..e6a610d 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -2181,6 +2181,9 @@ int gtp_update_pdp_conf(struct gsn_t *gsn, int version, if (gtp_conf(gsn, 0, peer, pack, len, &type, &cbp)) return EOF; + /* TODO This function is called from gtp_decaps1c() (for GTP v1) but + * uses gtp0.h.flow (GTP v0 data element) + */ /* Find the context in question */ if (pdp_getgtp0(&pdp, ntoh16(((union gtp_packet *)pack)->gtp0.h.flow))) { gsn->err_unknownpdp++; @@ -2194,6 +2197,9 @@ int gtp_update_pdp_conf(struct gsn_t *gsn, int version, /* Register that we have received a valid teic from GGSN */ pdp->teic_confirmed = 1; + /* TODO This function is called from gtp_decaps1c() (for GTP v1) but + * explicitly passes version 0 and GTP0_HEADER_SIZE to gtpie_decaps() + */ /* Decode information elements */ if (gtpie_decaps (ie, 0, pack + GTP0_HEADER_SIZE, len - GTP0_HEADER_SIZE)) { -- cgit v1.2.3