diff options
author | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2015-10-12 14:26:49 +0200 |
---|---|---|
committer | Neels Hofmeyr <nhofmeyr@sysmocom.de> | 2015-10-12 14:30:10 +0200 |
commit | 746179370c89589ce9a4e959740a8f551a27d935 (patch) | |
tree | 56e1c4bb6ff188c80af37616a86d0c483520cea6 | |
parent | 5e0586df38fce1bb6edb734c1e4d1f4d9242a1f6 (diff) |
gtp.c: add todo comments
Sponsored-by: On-Waves ehi
-rw-r--r-- | gtp/gtp.c | 6 |
1 files changed, 6 insertions, 0 deletions
@@ -2181,6 +2181,9 @@ int gtp_update_pdp_conf(struct gsn_t *gsn, int version, if (gtp_conf(gsn, 0, peer, pack, len, &type, &cbp)) return EOF; + /* TODO This function is called from gtp_decaps1c() (for GTP v1) but + * uses gtp0.h.flow (GTP v0 data element) + */ /* Find the context in question */ if (pdp_getgtp0(&pdp, ntoh16(((union gtp_packet *)pack)->gtp0.h.flow))) { gsn->err_unknownpdp++; @@ -2194,6 +2197,9 @@ int gtp_update_pdp_conf(struct gsn_t *gsn, int version, /* Register that we have received a valid teic from GGSN */ pdp->teic_confirmed = 1; + /* TODO This function is called from gtp_decaps1c() (for GTP v1) but + * explicitly passes version 0 and GTP0_HEADER_SIZE to gtpie_decaps() + */ /* Decode information elements */ if (gtpie_decaps (ie, 0, pack + GTP0_HEADER_SIZE, len - GTP0_HEADER_SIZE)) { |